Bug 357039 - kwalletmanager5 config module has incomplete authAction
Summary: kwalletmanager5 config module has incomplete authAction
Status: RESOLVED WORKSFORME
Alias: None
Product: kwalletmanager
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources All
: NOR major
Target Milestone: ---
Assignee: Valentin Rusu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 13:07 UTC by RJVB
Modified: 2022-11-14 05:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description RJVB 2015-12-22 13:07:12 UTC
The configuration module of the current kwalletmanager version begins to set up an authentication action required for saving changes to the wallet configuration, but fails to add the actual authAction. As a result, saving becomes impossible because `authAction().isValid == false`.

Reproducible: Always

Steps to Reproduce:
N/A

Actual Results:  
authAction.isValid() evaluates to falls, and as a result it is impossible to save changes to the wallet configuration

Expected Results:  
changes to the configuration can be saved

either setAuthAction() is called to define an authentication action, or else the code setting up an authentication requirement should be stripped like with the patch below.

--- src/konfigurator/orig.konfigurator.cpp   2015-12-22 01:46:08.000000000 +0100
+++ src/konfigurator/konfigurator.cpp   2015-12-22 01:46:57.000000000 +0100
@@ -60,7 +60,7 @@
                      QStringLiteral(),
                      QStringLiteral("staikos@kde.org"));
     setAboutData(about);
-    setNeedsAuthorization(true);
+    setNeedsAuthorization(false);
 
     QVBoxLayout *vbox = new QVBoxLayout(this);
     //PORT QT5 vbox->setSpacing(KDialog::spacingHint());
@@ -267,18 +267,19 @@
     QVariantMap args;
     KAuth::Action action = authAction();
     if (!action.isValid()) {
-        qDebug() << "There's no authAction, not saving settings";
-        return;
-    }
-    action.setArguments(args);
+//         qDebug() << "There's no authAction, not saving settings";
+//         return;
+    } else {
+        action.setArguments(args);
 
-    KAuth::ExecuteJob *j = action.execute();
+        KAuth::ExecuteJob *j = action.execute();
 
-    if (!j->exec()) {
-        qDebug() << j->errorText();
-        KMessageBox::error(this, j->errorString(), i18n("KDE Wallet Control Module"));
-        load();
-        return;
+        if (!j->exec()) {
+            qDebug() << j->errorText();
+            KMessageBox::error(this, j->errorString(), i18n("KDE Wallet Control Module"));
+            load();
+            return;
+        }
     }
 
     KConfigGroup config(_cfg, "Wallet");
Comment 1 Justin Zobel 2022-10-15 10:59:48 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported and confirmed, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 2 Bug Janitor Service 2022-10-30 05:03:49 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2022-11-14 05:16:45 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!