Bug 357029 - Empty kickoff favorites menu on first start with new user/empty profile
Summary: Empty kickoff favorites menu on first start with new user/empty profile
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.5.1
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 06:18 UTC by Markus
Modified: 2016-03-27 08:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to fix obsolete_kickoffrc.js (1.29 KB, patch)
2016-02-14 04:52 UTC, Markus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus 2015-12-22 06:18:48 UTC
With plasma 5.5 the favorites menu on kickoff is empty on first start with a new profile/user. Previous to Plasma 5.5 there was systemsettings, browser, file-manager and text-editor as default favorites.
When using the alternative launcher kicker the favorites are there. There is no old "kickoffrc" where kickoff could read a previous configuration so this is different to Bug 356398.

Reproducible: Always




Here is the org.kde.plasma.desktop-appletsrc after first login to a new profile/user. If i add applications manually to the list of favorites they will appear in
 [Containments][1][Applets][2][Configuration][General] favorites=...
which is empty on first start. I wonder about
 [Containments][1][Applets][2][Configuration] favorites=\\0 
Should favorites=\\0 be there?

=======================================================
[ActionPlugins][0]
MidButton;NoModifier=org.kde.paste
RightButton;NoModifier=org.kde.contextmenu
wheel:Vertical;NoModifier=org.kde.switchdesktop

[ActionPlugins][1]
RightButton;NoModifier=org.kde.contextmenu

[ActionPlugins][127]
RightButton;NoModifier=org.kde.contextmenu

[Containments][1]
activityId=
formfactor=2
immutability=1
lastScreen=0
location=4
plugin=org.kde.panel
wallpaperplugin=org.kde.image

[Containments][1][Applets][2]
immutability=1
plugin=org.kde.plasma.kickoff

[Containments][1][Applets][2][Configuration]
favorites=\\0
systemApplications=systemsettings.desktop,

[Containments][1][Applets][2][Configuration][General]
favorites=
systemApplications=systemsettings.desktop,

[Containments][1][Applets][2][Configuration][Shortcuts]
global=Alt+F1

[Containments][1][Applets][2][Shortcuts]
global=Alt+F1

[Containments][1][Applets][3]
immutability=1
plugin=org.kde.plasma.pager

[Containments][1][Applets][4]
immutability=1
plugin=org.kde.plasma.taskmanager

[Containments][1][Applets][5]
immutability=1
plugin=org.kde.plasma.systemtray

[Containments][1][Applets][5][Configuration][Containments][8]
formfactor=2
location=4

[Containments][1][Applets][5][Configuration][Containments][8][Applets][10]
immutability=1
plugin=org.kde.plasma.notifications

[Containments][1][Applets][5][Configuration][Containments][8][Applets][11]
immutability=1
plugin=org.kde.plasma.printmanager

[Containments][1][Applets][5][Configuration][Containments][8][Applets][12]
immutability=1
plugin=org.kde.plasma.devicenotifier

[Containments][1][Applets][5][Configuration][Containments][8][Applets][13]
immutability=1
plugin=org.kde.plasma.clipboard

[Containments][1][Applets][5][Configuration][Containments][8][Applets][9]
immutability=1
plugin=org.kde.discovernotifier

[Containments][1][Applets][5][Configuration][General]
extraItems=org.kde.plasma.devicenotifier,org.kde.plasma.networkmanagement,org.kde.plasma.mediacontroller,org.kde.plasma.clipboard,org.kde.plasma.notifications,org.kde.discovernotifier,org.kde.plasma.battery,org.kde.plasma.printmanager,org.kde.plasma.bluetooth
knownItems=org.kde.plasma.devicenotifier,org.kde.plasma.networkmanagement,org.kde.plasma.mediacontroller,org.kde.plasma.clipboard,org.kde.plasma.notifications,org.kde.discovernotifier,org.kde.plasma.battery,org.kde.plasma.printmanager,org.kde.plasma.bluetooth

[Containments][1][Applets][6]
immutability=1
plugin=org.kde.plasma.digitalclock

[Containments][1][General]
AppletOrder=2;3;4;5;6

[Containments][7]
activityId=cb7ff7b4-d314-4e60-84ba-d6f673ed4af3
formfactor=0
immutability=1
lastScreen=0
location=0
plugin=org.kde.desktopcontainment
wallpaperplugin=org.kde.image

[Containments][7][Wallpaper][org.kde.image][General]
height=768
width=1024
=======================================================
Comment 1 Markus 2016-02-14 04:51:48 UTC
This problem is related to desktoppackage/contents/updates/obsolete_kickoffrc.js

It looks like that this script tries to migrate from an existing kickoffrc file. If this config file does not exist like when you login for the first time with an empty profile the favorites page on kickoff will be empty.

I removed this file from plasma-desktop package and now everything is fine.

Also obsolete_kickoffrc.js seem to add the config options for favorites to the wrong config group.

This is how it looks when migrating from a non existing kickoffrc file:
[Containments][1][Applets][2][Configuration]
favorites=\\0
systemApplications=systemsettings.desktop,

This config options should be added to the [General] group.
[Containments][1][Applets][2][Configuration][General]
favorites=
systemApplications=systemsettings.desktop, 

For some reason existing favorites from the kickoffrc file will not be added. All i get is favorites=\\0.

I patched obsolete_kickoffrc.js, see attached patch #1. This seem to fix migrating favorites and also puts the config options to the correct config group.
Comment 2 Markus 2016-02-14 04:52:53 UTC
Created attachment 97190 [details]
Patch to fix obsolete_kickoffrc.js

This will fix migrating from kickoffrc file...
Comment 3 Rex Dieter 2016-03-23 16:06:05 UTC
I can confirm this on fedora (kf5-5.19, plasma-5.5.5)
Comment 4 Eike Hein 2016-03-27 08:04:23 UTC
Git commit bc28403a08c81d2c07c4582622d9c138ede24704 by Eike Hein.
Committed on 27/03/2016 at 08:03.
Pushed by hein into branch 'Plasma/5.6'.

Set config group.

M  +10   -6    desktoppackage/contents/updates/obsolete_kickoffrc.js

http://commits.kde.org/plasma-desktop/bc28403a08c81d2c07c4582622d9c138ede24704
Comment 5 Eike Hein 2016-03-27 08:14:14 UTC
Git commit fc9a550fbd0cb51f5342972948c38129de1bac35 by Eike Hein.
Committed on 27/03/2016 at 08:13.
Pushed by hein into branch 'Plasma/5.6'.

Handle non-existing kickoffrc correctly.

M  +16   -8    desktoppackage/contents/updates/obsolete_kickoffrc.js

http://commits.kde.org/plasma-desktop/fc9a550fbd0cb51f5342972948c38129de1bac35