Bug 357005 - timezones not sorted by date/time in the tooltip
Summary: timezones not sorted by date/time in the tooltip
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock widget (other bugs)
Version First Reported In: master
Platform: Other All
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-21 16:54 UTC by Pino Toscano
Modified: 2016-01-04 18:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pino Toscano 2015-12-21 16:54:58 UTC
The timezones in the tooltip of the applet are not sorted by the date/time.
The list of timezones has no apparent order, making it awkward to spot easily the places "ahead" or "behind" the current time; they should be better sorted by the date/time first, then the place name.

This, together with #351472 and #357004, makes a bit of regressions in the digital applet, compared to plasma in kde4.
Comment 1 Kai Uwe Broulik 2015-12-21 22:43:06 UTC
It looks like they're "sorted" by the order they were added by the user. Indeed, they should be sorted by time.
Comment 2 Martin Klapetek 2016-01-04 18:03:37 UTC
Git commit f5297033c4a0fba416b971f2bdbcb04c56858947 by Martin Klapetek.
Committed on 04/01/2016 at 18:03.
Pushed by mklapetek into branch 'master'.

[digital-clock] Improve clock's tooltip layout

In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.

Also simplifies the timeForZone function which is used only for the
tooltip.
Related: bug 351472, bug 357004
FIXED-IN: 5.6.0
REVIEW: 124047

M  +11   -57   applets/digital-clock/package/contents/ui/DigitalClock.qml
A  +137  -0    applets/digital-clock/package/contents/ui/Tooltip.qml     [License: LGPL (v2+)]
M  +10   -3    applets/digital-clock/package/contents/ui/main.qml
M  +1    -0    applets/digital-clock/plugin/timezonedata.h
M  +18   -1    applets/digital-clock/plugin/timezonemodel.cpp
M  +3    -0    applets/digital-clock/plugin/timezonemodel.h

http://commits.kde.org/plasma-workspace/f5297033c4a0fba416b971f2bdbcb04c56858947