Using the latest package from vpinon's PPA, I noticed that when I import a clip into a new Kdenlive project, it no longer seems to check and pop up a message allowing me to match the project settings to the clip. I have the "Check if first added clip matches project profile" setting turned on, but it doesn't seem to make any difference any more. Reproducible: Always Steps to Reproduce: 1. Open a new Kdenlive project 2. Import a clip that has different resolution / framerate than the project settings 3. Drag clip to timeline Actual Results: Clip appears on timeline. No warning about it having different settings. Expected Results: Clip appears on timeline. The old popup warning you that the clips settings are different to the projects settings appears. The project settings that most closely match the clips are suggested.
Git commit 31a2a12998a199d1624ed1489d30b6b978a97e72 by Jean-Baptiste Mardelle. Committed on 31/12/2015 at 22:23. Pushed by mardelle into branch 'master'. Reintroduce improved check first clip feature. Now, when enabled, Kdenlive will automatically switch its profile and inform user M +6 -0 src/bin/bin.cpp M +2 -0 src/bin/bin.h M +23 -4 src/definitions.cpp M +1 -0 src/definitions.h M +19 -28 src/dialogs/profilesdialog.cpp M +3 -0 src/dialogs/profilesdialog.h M +33 -0 src/doc/kdenlivedoc.cpp M +1 -0 src/doc/kdenlivedoc.h M +2 -1 src/mainwindow.cpp M +1 -1 src/monitor/glwidget.cpp M +1 -0 src/monitor/monitor.cpp M +2 -1 src/monitor/monitormanager.h M +17 -0 src/renderer.cpp M +2 -0 src/renderer.h http://commits.kde.org/kdenlive/31a2a12998a199d1624ed1489d30b6b978a97e72
Currently, Kdenlive automatically switches the profile, as you describe it. Video: https://youtu.be/4Ho13WMHvtI However this doesn't really match the setting name. I would suggest that the user gets to decide whether the profile is switched or not and is presented with information about the current profile and information about the profile to which it would switch. or The setting name is changed from "Check if first added clip matches project profile" to "Apply first added clip's profile to project". kdenlive-git 15.13.0.r6916.7084fa1-1 mlt-git r4157.v0.9.2.379.g676fcd8-1
Created attachment 96654 [details] profile switch question Correct. I am thinking about changing the behavior to not switch profile automatically, but show a non blocking popup with button allowing to switch. (see screenshot). Ok for that ? comments ?
Non-blocking pop ups are great. My feeling is that there's not enough information though. Not knowing profile details can confuse, there can be profile duplicates, this question can make you insecure in the "wait, what profile am I using anyway?" way. So I'd add information about the current profile and include the main properties of both profiles (resolution and frame rate) As far as I'm aware of UI/UX concepts, I believe decision buttons need to be clear, so all information should be in the popup and the buttons should be a clear yes/no. "Ignore" sounds like there's a problem, so I wouldn't use that. I would suggest the message: "Switch current project profile (HD 1080p 24fps, 1920x1080, 24fps) to clip profile (DV/DVD PAL, 800x600, 24fps)?" which is "Switch current project profile (PROJECTPROFILENAME[can be trimmed], PROJECTRESOLUTION, PROJECTFPS) to clip profile (CLIPPROFILENAME, CLIPRESOLUTION, CLIPFPS)?" and the options "Continue / Cancel" or "OK / Cancel" or "Yes / Cancel" or "Switch / Cancel" Continue looks too similar to Cancel, so I wouldn't use it, even though it's what the current project/project profile/change profile question offers (but at least they differ in color there). If possible, please test: 1. What happens when project bin is hidden during import of first different-profile clip? (can be done via menu) 2. What happens when you press space or enter/return after importing first different-profile clip? It should probably not select one of the two options because one of them gets auto-selected.
PS: I haven't actually seen how this comparably huge block of text would look like, so this is just a naive suggestion. You solution already is great
Created attachment 96666 [details] Auto profile detect - 2 This is with the complete text. Comments?
Thanks for the effort! First thought: too much text. I'd go with > Switch to clip profile DV/DVD PAL, 1920x1080, 25fps? or > Switch to clip profile DV/DVD PAL? and > Switch / Cancel As a bonus: if possible, it'd be great to not show decimal zeroes for integer fps (24, 25, 30, 48, 50, 60 etc.)
Git commit 91a2803c10c917ad3dc04d210736f68fdae37c59 by Jean-Baptiste Mardelle. Committed on 16/01/2016 at 14:31. Pushed by mardelle into branch 'master'. Ask user before switching to clip profile when adding first clip to project M +21 -10 src/bin/bin.cpp M +7 -4 src/bin/bin.h M +41 -0 src/definitions.cpp M +3 -0 src/definitions.h M +38 -8 src/doc/kdenlivedoc.cpp M +1 -0 src/doc/kdenlivedoc.h M +5 -7 src/mltcontroller/producerqueue.cpp M +1 -1 src/project/jobs/jobmanager.cpp http://commits.kde.org/kdenlive/91a2803c10c917ad3dc04d210736f68fdae37c59
It seems to work great with known formats (video: https://youtu.be/H4vPBT8Cw7Y ) Cosmetics: It feels weird to see the resolution/fps when they are already part of the profile name. Putting them in (parenthesis) might make it easier to read. Adding for example a nonstandard svg confuses the importer though, it suggests using PAL and at the same time makes a popup suggesting the creation of a new profile. Video: https://youtu.be/UJZ43j1PQnY
Git commit 2509e9b436936b5e0f9e2cb2ac713d712f2ba1e3 by Jean-Baptiste Mardelle. Committed on 16/01/2016 at 23:10. Pushed by mardelle into branch 'master'. Fix small popup label and double message on unknown profile M +1 -1 src/definitions.cpp M +1 -1 src/doc/kdenlivedoc.cpp M +1 -7 src/mltcontroller/producerqueue.cpp http://commits.kde.org/kdenlive/2509e9b436936b5e0f9e2cb2ac713d712f2ba1e3
Great work! Testing video: https://youtu.be/4ysOjreemUw 1. SVG is treated well now (resolution suggestion matches SVG size). 2. When images are added, the suggested FPS appears to be based on the current project's. Seems like a very sensible solution! 3. The pop-up which shows up if the first clip doesn't match a profile I find a bit confusing. > No existing profile found for your clip (960x1061, 29,97fps) > Do you want to switch to that custom profile? > Yes / No My thoughts are: what is a "custom" profile, question references other sentence, making interaction possibly too long, "existing" profile might be unclear as well. I'd suggest > Create and switch to new profile (960x1061, 29.97fps)? > Continue / Cancel With "Continue" being highlighted. On one hand it would be nice if it would be in the project bin, just like the other message is but on the other hand it is a more meaningful decision, so a popup might be the right choice as well. One could also have the popup only ask for creation of a new profile and if it's answered positively, the usual "Switch to ..." message could appear afterwards. But that might be too confusing and maybe problematic to implement. 4. I'd remove the "," before the " (" in > Switch to clip profile DV/DVD PAL, (1920x1080, 25fps)? to make it > Switch to clip profile DV/DVD PAL (1920x1080, 25fps)? 5. I tested importing clips with project bin hidden. No crash, no freeze. You simply don't get the "switch profile?" question unless you turn on project bin which is probably not a problem.
Git commit dcd2511b64855e191a877788693298762cb144db by Jean-Baptiste Mardelle. Committed on 17/01/2016 at 19:05. Pushed by mardelle into branch 'master'. Rephrase message on unknown profile. Make sure profile created from clip has width multiple of 8 (required in some parts of MLT) M +8 -8 src/bin/bin.cpp M +1 -1 src/definitions.cpp M +6 -2 src/doc/kdenlivedoc.cpp http://commits.kde.org/kdenlive/dcd2511b64855e191a877788693298762cb144db
Kubuntiac, is this bug fixed for you? Can you please test with a recent stable 16.04.2 or beta 16.07.xx version of Kdenlive, and MLT 6.2.0+? If the bug is fixed, then please be so kind as to close this bug report. Thank you very much for your cooperation!