Bug 356928 - TextLabel's font size is too big when changed to oxygen theme
Summary: TextLabel's font size is too big when changed to oxygen theme
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-20 02:20 UTC by Leslie Zhai
Modified: 2015-12-21 05:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Leslie Zhai 2015-12-20 02:20:53 UTC 
As snapshots shown as below:

https://pbs.twimg.com/media/CWfVHgxVEAAvGYd.png

https://pbs.twimg.com/media/CWfVHguUkAAYUfP.png

When changed to oxygen theme, there are topMargin and bottomMargin for TextLabel, so the boundingRect's height is NOT big enouth to hold GeneralFont size.

Reproducible: Always
Comment 1 Kai Uwe Broulik 2015-12-20 13:53:03 UTC 
I can't make out anything on those tiny screenshots, however I know what you mean.
Comment 2 Leslie Zhai 2015-12-21 01:29:47 UTC 
Hi Kai,

sorry twitter scaled the snapshot ;P but you can click the thumbnail to see the larger one  https://twitter.com/xiangzhai/status/677744595317293056

and I have followed the KDE coding style, please review my patch https://git.reviewboard.kde.org/r/126412/

Thanks a lot ;-)

Regards,
Leslie Zhai