Bug 356622 - Cannot change the group in the login form, and specifying it in the config results in not showing the login form (openconnect)
Summary: Cannot change the group in the login form, and specifying it in the config re...
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: applet (show other bugs)
Version: 5.5.0
Platform: Fedora RPMs Linux
: NOR grave
Target Milestone: ---
Assignee: Jan Grulich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 19:11 UTC by emelenas
Modified: 2015-12-14 09:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description emelenas 2015-12-13 19:11:38 UTC
This happens while connecting to a VPN server using openconnect, The server has several groups. A combo shows the different groups as options for the login form, and the first one is shown as selected in the combo.  If I try to change it, the combo reverts to the first, not keeping my selection. If I change the form:main:group_list key in the NetworkManager config file, it does not show the login form. Clicking the connect button immediately tries to connect, which fails showing the message "Connection attempt was unsuccessful" (presumably because of a group/username/password mismatch). 
Connection with command-line openconnect proceeds successfully for the "group".

Reproducible: Always

Steps to Reproduce:
1. Trigger the VPN connection
2. Select a group that is not the first
or 
2. Have the group changed in the config file and attempt the connection


Actual Results:  
In the first case, the group is not changed in the combo. When clicking any other combo entry, the item shown is always the first.

If the group is set in the config file, the login form is not shown. If the connection is attempted,  no password can be entered and the attempt fails with the message  "Connection attempt was unsuccessful".

Expected Results:  
In the first case, expect to see the combo entry changed, and be able to login afterwards.

In the second, expect the login form to be shown with the selected entry and the connection to succeed after the login and password information has been entered 

Previous version 5.4.3 worked fine
Comment 1 Jan Grulich 2015-12-14 09:18:12 UTC
Git commit c004d3563a08ed9519be20c98861999ea72faa42 by Jan Grulich.
Committed on 14/12/2015 at 09:18.
Pushed by grulich into branch 'master'.

Fix openconnect dialog

Previous patch removing "Show passwords" checkbox changed layout order and
we forgot to address that.

Patch from Simon Munton
Related: bug 356587

M  +3    -19   vpn/openconnect/openconnectauth.cpp
M  +0    -1    vpn/openconnect/openconnectauth.h

http://commits.kde.org/plasma-nm/c004d3563a08ed9519be20c98861999ea72faa42
Comment 2 Jan Grulich 2015-12-14 09:18:49 UTC
Git commit 28c4b2e1b868427201cecb6d01cdb45ebfd157a0 by Jan Grulich.
Committed on 14/12/2015 at 09:18.
Pushed by grulich into branch 'Plasma/5.5'.

Fix openconnect dialog

Previous patch removing "Show passwords" checkbox changed layout order and
we forgot to address that.

Patch from Simon Munton
Related: bug 356587

M  +3    -19   vpn/openconnect/openconnectauth.cpp
M  +0    -1    vpn/openconnect/openconnectauth.h

http://commits.kde.org/plasma-nm/28c4b2e1b868427201cecb6d01cdb45ebfd157a0