Bug 356499 - Improve interface feedback visuals when moving effects in stack up and down in Properties Widget
Summary: Improve interface feedback visuals when moving effects in stack up and down i...
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: git-master
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL: https://youtu.be/FXNRDzyXIZA
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 00:51 UTC by Unknown
Modified: 2020-05-04 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2015-12-11 00:51:46 UTC
See video in URL field for examples and details:

Suggestions/Bugs include:
1. Properties tab shows a "..." on clips in timeline that don't have effects applied, while clips WITH Affects applied have full filenames. Recommend allowing the full file length to clips in properties tab that don't have effects.
2. When using mouse to move effects up and down, have the selection show line above or below showing where the effect would be placed, instead of the "Plus" icon on mouse.
3. Disabling effects in properties tab doesn't always disable effects properly

Reproducible: Always




Tested on Kdenlive 15.11.90+48 via vpinon's Wily ppa. Using Ubuntu GNOME 15.10 w/ Gnome 3.16
Comment 1 Unknown 2016-01-22 19:48:52 UTC
Looks like issue #1 has been reversed. Now it only shows a "..." when the clip in timeline HAS an effect applied -- even if you enlarge the widget to give more room for the file name, it still shows a ...

It looks like issue #3 has been resolved after a little testing with the latest kdenlive-git master builds.
Comment 2 Jean-Baptiste Mardelle 2016-01-23 14:38:41 UTC
Strange, I cannot reproduce. Can you paste here the name of one of the clips that reproduces the problem ? When you put your mouse over the "Effect for ..." label, do you get a tooltip with full name of the clip ?
Comment 3 Unknown 2016-01-26 17:58:56 UTC
Hey JB, regarind issue #1, here's a link to a video example of what I'm talking about. https://youtu.be/e982xnZmeEs

Small correction: testing the latest Kdenlive master build, looks like this applies to both when an effect is applied to the clip or not. Sorry for the confusion.

It's a very minor bug; the tooltip shows the clip name anyways. If you figure it's not a big deal, I'd disregard issue #1 and only consider if #2 is worth implementing. :)
Comment 4 Jean-Baptiste Mardelle 2016-01-27 23:57:43 UTC
Git commit 06b4bd00a5a91bcb254579333b2d66f1c0835900 by Jean-Baptiste Mardelle.
Committed on 27/01/2016 at 23:57.
Pushed by mardelle into branch 'master'.

Make Effect Properties checkbox label resize to content, do some cleanup

M  +0    -2    src/CMakeLists.txt
M  +34   -68   src/effectstack/effectstackview2.cpp
M  +2    -3    src/effectstack/effectstackview2.h
M  +1    -1    src/monitor/scopes/audiographspectrum.h
M  +1    -0    src/project/CMakeLists.txt
A  +123  -0    src/project/effectsettings.cpp     [License: GPL]
A  +67   -0    src/project/effectsettings.h     [License: GPL]

http://commits.kde.org/kdenlive/06b4bd00a5a91bcb254579333b2d66f1c0835900
Comment 5 Unknown 2016-03-08 21:46:13 UTC
UPDATE: Issues #1 and #3 seem to be resolved/fixed in the latest git master builds of Kdenlive. Thanks JB!

The final item in this report is merely a suggestion. If not found best, feel free to close this bug. :)

Thanks.
Comment 6 farid 2016-10-22 14:05:00 UTC
Can we close this?
Comment 7 Unknown 2016-10-23 18:20:52 UTC
Honestly? The more I use it, the more I feel #2 in this report needs to be addressed. Having the plus sign when moving effects around the Properties widget and highlighting other effects while click+dragging doesn't express a stack-type hierarchy. I can expand on suggestions to improve the interface it the OP doesn't satisfy.
Comment 8 emohr 2020-04-04 17:47:45 UTC
I think point 2 and 3 is implemented in version 20.12. Please test.
Comment 9 Bug Janitor Service 2020-04-19 04:33:10 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Bug Janitor Service 2020-05-04 04:33:12 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!