When you customize the Kdenlive layout, then go to the top menu bar, click on View > Save Layout As > ... , it shows "Save as Layout 1", "Save as Layout 2", etc. Loading the Layout, however, doesn't have "Load Layout 1", "Load Layout 2", etc. Consider the following changes: 1. Remove "Save as Layout..." from "Save Layout as" submenu, simply replacing them with "Layout 1", "Layout 2", etc. 2. Change "Save Layout as" in the View menu to simply "Save Layout", similar to the "Load Layout" option beneath it. Reproducible: Always Tested on Kdenlive 15.11.90+48 from vpinon's Wily ppa. Using Ubuntu GNOME 15.10 w/ Gnome 3.16.
You can just remove "Save As " from kdenlive/src/layoutmanagement.cpp on line 34. But I am not sure if current msgid "Save As Layout %1" will be automatically removed from po files of translation teams.
Please, see this patch on review board: https://git.reviewboard.kde.org/r/130008/
Thanks for submitting that patch, Ashark. I'd actually performed that commit on my forked github repo, but I guess that I didn't know the whole steps to submit the patch for review. :) Still so much to learn! Hoping to hear back from the Kdenlive team -- would love to say I'd committed to the project beyond bug testing.
Hello, Jesse. Github is a read only mirror of KDE repositories. See this page: https://community.kde.org/Infrastructure/Github_Mirror But I saw your patch, and I think my is more "optimised". On line 69 you keep i18n("%1", layoutName)); to send a string. However, in this case i18n will just return %1 and then replace it with layoutName and after that this string could be used by setText. In my patch, I just give layoutName to setText: saveActions[j]->setText(layoutName); I suggest you to add [patch provided] to the title of this bug report and then it will be easy for team to spot and apply this patch.
By the way, this bug is screenshoted in features page in main site: https://kdenlive.org/features/
Created attachment 107280 [details] layoutmanagement.cpp file with patched code to fix the corresponding bug.
@Ashark, thanks for the info'. Alright, so I've been teaching myself C# and C++ (primarily for VR game design). I'm still a novice, but I feel I've sufficiently modified the code in layoutmanagement.cpp and would like to submit a patch for review. This is my first time submitting a patch, so feel free to correct me on what I should/shouldn't be doing. I'd recently attached a modified layoutmanagement.cpp file with the code changes for review and approval. How do things proceed from here?
My only concern with this is that if I remember correctly, loading and saving layouts can be assigned shortcuts. Currently, the "save as" part in the name helps differentiate between the load and save actions in the shortcut dialog. If we remove "save as", i am afraid both load and save actions will appear under "layout 1" in the shortcut dialog. Can uou check that ?
Yes, layouts will appear without differentiate. See attached screenshot.
Created attachment 107297 [details] Screenshot of layouts in shortcut menu after patch In shortcuts menu it will be difficult to differentiate actions for layouts.
Thanks JB and Ashark. I definitely see the concern, there. Give me a bit to see if I can come up with a creative solution.
(And sorry, the bug tracker isn't emailing me when a new comment appears on a bug I'm following. Not sure why, so I have to check bugs for new comments, manually.)
Ashark, you're right about the optimized code. I replaced "setText(i18n("%1", layoutName))" with "setText(layoutName). Apprecaite the guidance, there.
Could we possibly sub-categorize each of them in the Configure shortcuts window? For example: Layouts - Save Layout - - Layout 1 - - Layout 2 - - Layout 3 - - Layout 4 - Load Layout - - Layout 1 - - Layout 2 - - Layout 3 - - Layout 4
Yes, I was also thinking about it. Shouldn't be hard. in layoutmanagement.cpp at line 27, we gave: KActionCategory *layoutActions = new KActionCategory(i18n("Layouts"), pCore->window()->actionCollection()); Which puts items in a "Layout" category. So instead we can simply create 2 categories: "Load Layout" and "Save Layout", and put the actions in the correct category.
see here: https://invent.kde.org/kde/kdenlive/-/issues/407
New layout function with preset layouts, customized layout and save as will come with 20.08. We close this bug. If it still appears in the latest version, please feel free to re-open it and update the affected version number.