Bug 356383 - Add support for PHP 7 syntax additions
Summary: Add support for PHP 7 syntax additions
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (show other bugs)
Version: unspecified
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 09:24 UTC by Sebastian Bergmann
Modified: 2017-07-25 07:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.37


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Bergmann 2015-12-08 09:24:41 UTC
PHP 7 was released last week and introduces new syntax that Kate's syntax highlighting does not know about yet. It would be great if support for PHP 7's syntax addition could be added to Kate in a timely manner, the PHP community would surely appreciate that. I will gladly help in making this happen, however I have yet to learn how Kate's syntax highlighting works.

Please note that I neither use Kate nor KDE. I use pandoc for writing books. pandoc uses highlighting-kate, a syntax highlighting library in Haskell that uses Kate syntax definitions. At the end of the day what I need is support for PHP 7 syntax in pandoc. I hope I came to the right place to report this issue. If not then please point me in the right direction. Thanks!

Reproducible: Always
Comment 1 Dominik Haumann 2017-07-24 08:20:11 UTC
The latest php.xml file is here:
https://raw.githubusercontent.com/KDE/syntax-highlighting/master/data/syntax/php.xml

Could you just add all the keywords that are new in PHP 7 and then post either a patch, or attach the complete file ?
Comment 2 Dominik Haumann 2017-07-25 07:46:32 UTC
Git commit f5b765e90eeb55348708df51005b5acdef7841ab by Dominik Haumann.
Committed on 25/07/2017 at 07:46.
Pushed by dhaumann into branch 'master'.

PHP: Add PHP 7 keywords

Thanks to Sebastian Bergmann for the patch, see:
https://github.com/KDE/syntax-highlighting/pull/7/commits/c927606f80539127394847692acf21d1d90c9624

FIXED-IN: 5.37

M  +28   -1    data/syntax/php.xml

https://commits.kde.org/syntax-highlighting/f5b765e90eeb55348708df51005b5acdef7841ab
Comment 3 Dominik Haumann 2017-07-25 07:47:26 UTC
@Sebastian: Thanks a lot for your pull request. I merged your changes into the syntax-highlighting.git, these changes are available in KDE Frameworks v5.37.