Bug 356300 - Moving multiple clips in timeline vertically is recorded incorrectly for undo history (undo will move in wrong direction)
Summary: Moving multiple clips in timeline vertically is recorded incorrectly for undo...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-05 00:23 UTC by qubodup
Modified: 2015-12-14 21:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 15.12.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description qubodup 2015-12-05 00:23:16 UTC
catalyst-hook 15.9-6
catalyst-libgl 15.9-2
catalyst-utils 15.9-2
mlt 0.9.8-3
qt5-base 5.5.1-3
kdenlive git describe --tags --always
v15.11.80-53-g0918054

Steps to reproduce:
1. Create color clip
2. Drag clip to beginning of video track 1, 2 and 3.
3. Select all clips
4. Move clips down by one track (v2, v3, a1)
5. Press Ctrl+Z to undo

Expected result:
1. Clips "jump" back to previous position (v1,v2,v3)

Actual result:
1. Clips "jump" further down (v3, a1, a2)

Video: https://youtu.be/dv_iaqf7oQE

Note:
If you do this with v2/v3/a1/ moving to v3/a1/a2 and then save the project, close and reload it, then the project will be different. Video: https://youtu.be/cDQC3qJTgFc
Comment 1 Jean-Baptiste Mardelle 2015-12-05 08:22:17 UTC
Git commit adce4be26d61d99bf59c4190914ad1015ed8a9e2 by Jean-Baptiste Mardelle.
Committed on 05/12/2015 at 08:21.
Pushed by mardelle into branch 'Applications/15.12'.

Fix undoing group move goes to wrong track

M  +1    -1    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/adce4be26d61d99bf59c4190914ad1015ed8a9e2
Comment 2 qubodup 2015-12-05 12:08:24 UTC
The issue persists.

The issue was about moving three tracks that are selected at the same time. They were not grouped however.

The change might have possibly introduced a new issue: moving a group of clips automatically moves them to the bottom.

Video: https://youtu.be/_EMfo-oNf4k

For reference the Arch Linux 15.08.3 release has neither of these two issues.
Comment 3 Jean-Baptiste Mardelle 2015-12-05 13:14:29 UTC
I just realized you are using the master branch! All my recent changes were made in the 15.12 branch and have not been backported, so basically a lot of things have changed that are not in master!! I am merging right now, you can just update master to get the latest changes.

Let me know if you still find problems, and thanks for your reports.
Comment 4 qubodup 2015-12-05 14:36:34 UTC
Oh, sorry for not noticing!

No issues in current head now. Thanks!

I will make sure to look at the "heads" section in https://quickgit.kde.org/?p=kdenlive.git to figure out which branch has the latest changes (can't find a way using cli git only) and test that one before reporting.