Bug 356212 - Breeze-dark icons theme missing inherited icons (#345957 is back)
Summary: Breeze-dark icons theme missing inherited icons (#345957 is back)
Status: CLOSED NOT A BUG
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.4.2
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Uri Herrera
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 22:02 UTC by Modestas Vainius
Modified: 2015-12-14 16:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Dolphin with Breeze theme (14.22 KB, image/png)
2015-12-02 22:41 UTC, Modestas Vainius
Details
Dolphin with Breeze Dark theme (14.12 KB, image/png)
2015-12-02 22:41 UTC, Modestas Vainius
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Modestas Vainius 2015-12-02 22:02:10 UTC
Hello, andreas,

it seems that #345957 is back because your commit, fixing the problem:

https://quickgit.kde.org/?p=breeze.git&a=commit&h=6c9319e52e7f85b43b960eb8223f68d5890d1896

was reverted (index.theme part at least) in your next commit a month later:

https://quickgit.kde.org/?p=breeze-icons.git&a=commit&h=2c960dd98f08afed2f2e4226e4f5b3a73b70643d

Is this correct? As far as I can tell, as a result, breeze-dark theme is a bit crippled at the moment (using 5.4.3 here)

Reproducible: Always
Comment 1 Modestas Vainius 2015-12-02 22:04:51 UTC
Lost among repos. Original fix in breeze-icons.git here:

https://quickgit.kde.org/?p=breeze-icons.git&a=commit&h=07870ab1111dff258cbfd2e28869d21455fc7e85
Comment 2 andreas 2015-12-02 22:36:19 UTC
Hi,

in the past the breeze-dark icon set only include the monochrome icons. after this bug breeze and breeze-dark icons are standalone so you have all icons in breeze icons and breeze-dark icons so breeze wouldn't be the inherits of breeze-dark.

can you submit an screenshot
Comment 3 Modestas Vainius 2015-12-02 22:41:09 UTC
Created attachment 95872 [details]
Dolphin with Breeze theme
Comment 4 Modestas Vainius 2015-12-02 22:41:46 UTC
Created attachment 95873 [details]
Dolphin with Breeze Dark theme
Comment 5 Modestas Vainius 2015-12-02 22:43:19 UTC
See screenshots I attached. Quite a few icons in e.g. dolphin are missing.
Comment 6 andreas 2015-12-02 22:45:36 UTC
you cant use breeze dark icons on breeze color scheme. you need breeze dark color scheme if you want to use breeze dark icons. sorry this is a design decision when you use monochrome icons.
Comment 7 andreas 2015-12-02 22:47:29 UTC
you can't usw white icons in a white background.
Comment 8 Modestas Vainius 2015-12-02 22:53:31 UTC
Thank you. It makes sence. Not-a-bug here.
Comment 9 andreas_k 2015-12-03 05:22:11 UTC
but we work on this problem, so thanks for helping us to get better.