Bug 356165 - Theme misses any kinds of edges in non-compositting mode
Summary: Theme misses any kinds of edges in non-compositting mode
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-01 16:33 UTC by Martin Klapetek
Modified: 2019-12-12 17:39 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (89.21 KB, image/png)
2015-12-01 16:33 UTC, Martin Klapetek
Details
Screenshot after fix (5.21 KB, image/png)
2015-12-03 21:01 UTC, Martin Klapetek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2015-12-01 16:33:13 UTC
Created attachment 95846 [details]
Screenshot

When not using compositting, the Plasma stuff blends to windows and stuff because it does not seem to have any edges, making things very hard to recognize.

See screenshot.
Comment 1 Kai Uwe Broulik 2015-12-01 16:35:51 UTC
That's a problem with Breeze in general and affects the window decoration, too. Not sure if we want to put a lot of effort into that in 2015 though :)
Comment 2 Hugo Pereira Da Costa 2015-12-01 16:40:41 UTC
For the window decoration, it should not be "too" difficult to add a darker edge surrounding the decoration when compositing is inactive. 
Similar to what we have for menus.
And make the decoration square.
There was something like that for oxygen already.
Comment 3 Hugo Pereira Da Costa 2015-12-01 16:40:55 UTC
I'll give it a shot and report back.
Comment 4 Martin Klapetek 2015-12-01 16:48:53 UTC
> Not sure if we want to put a lot of effort into that in 2015 though

Surprisingly even in 2015 my intel laptop defaults to non-compositting after login :)
Comment 5 Hugo Pereira Da Costa 2015-12-01 16:56:51 UTC
(In reply to Martin Klapetek from comment #4)
> > Not sure if we want to put a lot of effort into that in 2015 though
> 
> Surprisingly even in 2015 my intel laptop defaults to non-compositting after
> login :)

eheh, maybe you should file a bug report :D
Comment 6 Hugo Pereira Da Costa 2015-12-01 19:44:34 UTC
Git commit 10145c7bb2f7ac791d8c3bc072cb9e644b8afa8d by Hugo Pereira Da Costa.
Committed on 01/12/2015 at 19:42.
Pushed by hpereiradacosta into branch 'master'.

when alpha channel is not supported,
- do not round corners
- draw a 1pixel frame around windows (when border is large enough)

M  +19   -4    kdecoration/breezedecoration.cpp
M  +7    -0    kdecoration/breezedecoration.h

http://commits.kde.org/breeze/10145c7bb2f7ac791d8c3bc072cb9e644b8afa8d
Comment 7 Hugo Pereira Da Costa 2015-12-01 19:50:03 UTC
So ... decoration part should be fixed (though subtle).
Can't help on the plasma theme. 
Leaving the bug open in case someone steps in :)
Comment 8 Martin Klapetek 2015-12-01 19:51:20 UTC
Thanks Hugo! Great work.
Comment 9 Marco Martin 2015-12-03 15:54:06 UTC
Git commit 1e1a75f7d3c7d754f934e690ff43edd6300df566 by Marco Martin.
Committed on 03/12/2015 at 15:50.
Pushed by mart into branch 'master'.

pixelperfect mask and border in non composite mode
Change-Id: If39de27d5374486cd3273e4bec2ecbe6556ea8f1

M  +-    --    src/desktoptheme/breeze/opaque/dialogs/background.svgz
M  +-    --    src/desktoptheme/breeze/opaque/widgets/panel-background.svgz
M  +-    --    src/desktoptheme/breeze/opaque/widgets/tooltip.svgz

http://commits.kde.org/plasma-framework/1e1a75f7d3c7d754f934e690ff43edd6300df566
Comment 10 Hugo Pereira Da Costa 2015-12-03 15:55:43 UTC
\o/
Team work !
Comment 11 Martin Klapetek 2015-12-03 21:01:15 UTC
Created attachment 95883 [details]
Screenshot after fix

Looks much better now, good stuff!

However it misses a pixel in every corner, see screenshot.
Comment 12 Alexander Mentyu 2018-02-21 13:07:13 UTC
Looks like this issue could be set as resolved
Comment 13 Nate Graham 2019-12-12 17:39:08 UTC
Yup, fixed now.