Bug 356087 - 15.11.80: extract frame does overwrite existing files without asking back
Summary: 15.11.80: extract frame does overwrite existing files without asking back
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-29 17:50 UTC by Wegwerf
Modified: 2015-12-14 21:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 15.12.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2015-11-29 17:50:16 UTC
When extracting a frame from either the clip or project monitor first a file dialog is shown. After either selecting an existing file or entering the name of an existing file this file will be overwritten without any warning.

In earlier versions of Kdenlive based on KDE4 there was a warning before overwriting existing files. 

Reproducible: Always

Steps to Reproduce:
1. Create new Kdenlive project.
2. Add a color clip to the project bin.
3. Drop color clip on timeline.
4. Position playhead within color clip in timeline.
5. In the project monitor right click, then choose "Extract frame..."
6. In the Save Image dialog then enter a new filename, such as extractedframe.png. Click Save.
7. Right click in the project monitor again, choose again "Extract frame..."
8. In the Save Image dialog select the same extractedframe.png again. Click Save.

Actual Results:  
Existing file gets overwritten without any warning.

Expected Results:  
Kdenlive should warn about an existing file being overwritten and asking the user to proceed or cancel.
Comment 1 Wegwerf 2015-11-29 18:13:59 UTC
System is Kubuntu 15.10 with Qt 5.4.2; KF 5.15.0.

This is strange as the QFileDialog instance seems to be correctly created. In fact, asking the QFileDialog about confirmOverwrite() returns "true". However, selecting an existing file does not trigger the QMessageBox warning prompt.
Comment 2 Jean-Baptiste Mardelle 2015-11-29 20:36:12 UTC
Git commit 1894b12d37d5a0e7b0329906d4604bdbcbc82e95 by Jean-Baptiste Mardelle.
Committed on 29/11/2015 at 20:35.
Pushed by mardelle into branch 'Applications/15.12'.

Warn before overwriting existing image file.

M  +20   -13   src/monitor/monitor.cpp
M  +1    -1    src/monitor/monitor.h

http://commits.kde.org/kdenlive/1894b12d37d5a0e7b0329906d4604bdbcbc82e95