Bug 356082 - Icon for save session is missing
Summary: Icon for save session is missing
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.5.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL: http://imgur.com/OePEndP
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-29 15:03 UTC by Ömer
Modified: 2016-05-28 21:59 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ömer 2015-11-29 15:03:41 UTC
I switched to manual save session since auto save/restore session is broken and saw that the menu entry save session has no icon.

Reproducible: Always

Steps to Reproduce:
1. Change to save manual session
2. Save session through k-menu



Frameworks: 5.16
Plasma: 5.5 Beta
Comment 1 andreas 2015-11-29 18:29:45 UTC
Screenshot please
Comment 2 Ömer 2015-11-30 12:44:59 UTC
http://imgur.com/OePEndP
Comment 3 andreas 2015-12-08 16:56:28 UTC
didn't know that there is an icon. do you know the icon Name?
Comment 4 Ömer 2015-12-08 17:11:46 UTC
No i don't. Any way to find out?
The k-menu entry doesn't really help right clicking only shows add to favourites.
Comment 5 Uri Herrera 2015-12-14 16:38:20 UTC
Add a screenshot with Oxygen.
Comment 6 Ömer 2015-12-16 10:53:45 UTC
seems like it is missing with oxygen to http://imgur.com/e4f3s92.
Comment 7 andreas 2016-05-28 00:16:05 UTC
If I get the icon name I can add it but I think it should be added to the plasma theme and therefore I need also the icon name. Maybe Marco Martin know the name
Comment 8 Ömer 2016-05-28 10:30:37 UTC
From https://github.com/KDE/plasma-desktop/blob/master/applets/kicker/plugin/systementry.cpp


QString SystemEntry::iconName() const
{
    switch (m_action) {
        case LockSession:
            return "system-lock-screen";
            break;
        case LogoutSession:
            return "system-log-out";
            break;
        case SaveSession:
            return "system-save-session";
            break;
        case SwitchUser:
            return "system-switch-user";
            break;
        case SuspendToRam:
            return "system-suspend";
            break;
        case SuspendToDisk:
            return "system-suspend-hibernate";
            break;
        case Reboot:
            return "system-reboot";
            break;
        case Shutdown:
            return "system-shutdown";
            break;
        default:
            break;
    }

    return QString();
}

So i would be guessing system-save-session?
Comment 9 andreas 2016-05-28 21:27:39 UTC
Git commit 56701aa3c173eda1a7d1e8d9e625316bb7f5b85b by andreas kainz.
Committed on 28/05/2016 at 21:27.
Pushed by andreask into branch 'master'.

update audio and network icon to get a better contrast

M  +-    --    src/desktoptheme/breeze/icons/audio.svgz
M  +-    --    src/desktoptheme/breeze/icons/network.svgz

http://commits.kde.org/plasma-framework/56701aa3c173eda1a7d1e8d9e625316bb7f5b85b
Comment 10 andreas 2016-05-28 21:31:44 UTC
sorry wrong bug number in the commit I fixed the bug 357726 with the commit.
Comment 11 andreas 2016-05-28 21:59:35 UTC
add system-save-session icon to master thank's for the icon naming.