Bug 356062 - Dolphin Filter by Baloo Tag
Summary: Dolphin Filter by Baloo Tag
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: filter (show other bugs)
Version: 15.08.2
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: junior-jobs, usability
: 401684 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-29 10:24 UTC by Jeff Dooley
Modified: 2022-01-10 16:22 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Mockup Tags Button (64.60 KB, image/png)
2018-10-17 04:00 UTC, Jeff Dooley
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Dooley 2015-11-29 10:24:04 UTC
It would be great if the Dolphin Filter bar could match items based on the file extended attributes (Baloo tags).

My installation:
Kubuntu 15.10
Dolphin 15.08.2
KDE Frameworks 5.15.0

Thank you!
Comment 1 Stefan Brüns 2018-10-16 18:16:04 UTC
You can search by tags by:
1. Dolphin -> Find -> ẗype "tags:<my tag name>"
2. Dolphin -> Click on the location bar (where e.g. "Home" is show) -> type "tags:/"

Is this essentially what you need?
Comment 2 Nate Graham 2018-10-17 01:52:50 UTC
(In reply to Stefan Brüns from comment #1)
> You can search by tags by:
> 1. Dolphin -> Find -> ẗype "tags:<my tag name>"
> 2. Dolphin -> Click on the location bar (where e.g. "Home" is show) -> type
> "tags:/"
> 
> Is this essentially what you need?

Those are okay, but not very discoverable, and don't relate to Dolphin's filter bar, which is what this request is about. To implement this on the filter bar, we could make tags tab-complete when you start typing them and turn into little tokens in the text field.
Comment 3 Jeff Dooley 2018-10-17 04:00:57 UTC
Created attachment 115698 [details]
Mockup Tags Button

To Nate's point, I was unaware of the features Stefan mentioned.

Nate's idea is great.

My thought at the time was more along the lines of a button (mockup-attached) which -> Tag Selection Dialog box. Right or wrong, the dialog box would at least mimic the behavior of the "Add Tags..." button present on the "Information" Side Panel in Dolphin.
Comment 4 Bogdan Bivolaru 2018-12-09 18:32:43 UTC
I would like to ask if you have already considered adding "TAGS" to the places panel? (in addition to TAB-autocomplete?)
I just did this for myself and it fills my need to overview the files categories.
Comment 5 Nate Graham 2019-01-02 00:14:11 UTC
*** Bug 401684 has been marked as a duplicate of this bug. ***
Comment 6 Ismael Asensio 2019-12-15 16:28:44 UTC
Git commit 8e80c1d6dc1ede9b0a44ea1bd949487280c17064 by Ismael Asensio.
Committed on 15/12/2019 at 16:28.
Pushed by iasensio into branch 'master'.

[dolphin/search] Search by (multiple) tags

Summary:
Adds a tag selector in the extended filters of the search box.
Selected tag or tags are added to the search query along with the other filters (type, date, rating).
Related: bug 412564

Test Plan:
- Menu shows the user tags
- Picking any tag/s filters the search to that specific tag/s

{F7727909}

Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg

Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg

Subscribers: kfm-devel

Tags: #dolphin

Maniphest Tasks: T9094

Differential Revision: https://phabricator.kde.org/D25130

M  +112  -4    src/search/dolphinfacetswidget.cpp
M  +14   -0    src/search/dolphinfacetswidget.h
M  +2    -1    src/search/dolphinquery.cpp
M  +27   -4    src/tests/dolphinquerytest.cpp

https://commits.kde.org/dolphin/8e80c1d6dc1ede9b0a44ea1bd949487280c17064
Comment 7 tagwerk19 2020-01-13 11:09:58 UTC
There's an alternate workflow that might need looking at as not given the "More Options" dialogs when looking at a 'Tags' view.

Use case: Open tags:/mytag/ (where you have given some items a 'mytag' tag and ratings) and then try to find items with a greater then 'X' star rating

Desired State: To be able to open a tag view and then list just items with a specific rating
Comment 8 Ismael Asensio 2020-06-13 17:39:55 UTC
(In reply to tagwerk19 from comment #7)
> There's an alternate workflow that might need looking at as not given the
> "More Options" dialogs when looking at a 'Tags' view.
> 
> Use case: Open tags:/mytag/ (where you have given some items a 'mytag' tag
> and ratings) and then try to find items with a greater then 'X' star rating
> 
> Desired State: To be able to open a tag view and then list just items with a
> specific rating

This is a sensible request. I can look into it.
Would you mind to open a new report for it under dolphin/search, so it's easier to track it? Thanks!
Comment 9 vini.ipsmaker 2020-07-12 03:03:27 UTC
I'd like to search for items in coroutines tag *not* in already-read tag. Is this issue related or do I create a new one?
Comment 10 Stefan Brüns 2020-07-13 05:22:31 UTC
(In reply to tagwerk19 from comment #7)
> There's an alternate workflow that might need looking at as not given the
> "More Options" dialogs when looking at a 'Tags' view.
> 
> Use case: Open tags:/mytag/ (where you have given some items a 'mytag' tag
> and ratings) and then try to find items with a greater then 'X' star rating
> 
> Desired State: To be able to open a tag view and then list just items with a
> specific rating

The best here would be to drop the majority of the "tags:/" code and just redirect to "baloosearch://tag=foo" when you click on foo.

The whole tags code is just horrible. Try e.g. "deleting" a file in the tags:/ view - it warns you this a a non-reversible operation and then just removes the tag from the file.
Comment 11 tagwerk19 2020-07-13 11:15:46 UTC
The option to 'delete' a tag from an item certainly ends up with a scary dialog. The command is irreversible (if you've removed the tag) but the warning is over the top.

My standpoint is that tags are _incredibly_ useful and would hesitate to suggest or propose anything that removes functionality and the "tags:/" prefix is, I think, quite graspable

What I miss is a description of "what happens" when you type a "tags:/mytag": a mapping between the "tags:" syntax and a matching baloosearch command would be nice. A trouble I had was working out the differences between "tags:", "tags:/" and "tags://" (?) when using hierarchical tags, such as tags:thesethings/thatthing
Comment 12 Ismael Asensio 2020-07-15 16:34:21 UTC
(In reply to vini.ipsmaker from comment #9)
> I'd like to search for items in coroutines tag *not* in already-read tag. Is
> this issue related or do I create a new one?

This is, I think, what's implemented in https://invent.kde.org/system/dolphin/-/merge_requests/24 (to be released on dolphin 20.08), but I didn't understand the sentence fully. It indeed translates the "tags:/mytag" scheme to a "baloosearch:/tag=mytag" one, allowing to refine the search with further tags or options (rating, date, etc...). It might still have some rough edges though.

As for the original bug report itself, while the user said "filter by tag", the attachment clearly shows they were referring to add tags in the search box, which was introduced in 20.04 (https://phabricator.kde.org/D25130), so IMO this one could be closed.

The latter comments here are quite interesting. Maybe we can create a task/issue to discuss on the improvement of UI/UX/behavior of the tags functionallity? I just wouldn't want them to get missed in a just-related old bug report.
Comment 13 Jeff Dooley 2022-01-09 05:20:14 UTC
(In reply to Ismael Asensio from comment #12) 
> As for the original bug report itself, while the user said "filter by tag",
> the attachment clearly shows they were referring to add tags in the search
> box, which was introduced in 20.04 (https://phabricator.kde.org/D25130), so
> IMO this one could be closed.

I agree: the new interface is very helpful. Thank you!