Bug 356012 - Wish: Extra whitespace should be highlighted in git diff output
Summary: Wish: Extra whitespace should be highlighted in git diff output
Status: RESOLVED WORKSFORME
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-28 06:07 UTC by Jamie Smith
Modified: 2016-03-17 07:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jamie Smith 2015-11-28 06:07:05 UTC
If there is extra whitespace in diffs, reviewboard highlights it in red blocks. KDevelop git
Show Differences output should do the same thing.

Reproducible: Always

Steps to Reproduce:
Whitespace is hard to spot...git->Show Differences... .

Actual Results:  
The additional whitespace shows up only after the diff is posted to ReviewBoard or caught in an editor somewhere else, which is annoying and time-consuming to correct.

Expected Results:  
Git Show Differences should show red blocks or some other indication that extra whitespace is probably present, much like reviewboard's diff viewer.
Comment 1 Francis Herne 2016-03-14 13:03:21 UTC
The setting 'highlight trailing spaces' (Editor -> Appearance -> Whitespace Highlighting) applies to the diff view.

The appearance isn't so conspicuous by default, but you can change the colour 'Tab and Space Markers' to something colourful.

Additionally, setting 'Remove trailing spaces' (Editor -> Open/Save -> Automatic Cleanups on Save) to an option that isn't "Never" will prevent the whitespace from existing in the first place.
Comment 2 Jamie Smith 2016-03-17 00:12:03 UTC
Thanks, I should have looked through the editor options more thoroughly.