Bug 355960 - Content of splash screen to big
Summary: Content of splash screen to big
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (other bugs)
Version First Reported In: 4.90.90
Platform: Debian unstable Linux
: NOR minor
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL: https://www.dropbox.com/s/sbizcop1e77...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-26 18:44 UTC by peje66
Modified: 2015-12-02 11:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description peje66 2015-11-26 18:44:45 UTC
At work on a 2560 x 1440 DPI (108, 107) screen the content of the splash screen doesn't fit
At home on a 1680 x 1050 DPI set to (90, 88) screen the content fits.

See linked image.

Reproducible: Always
Comment 1 Milian Wolff 2015-11-28 00:18:52 UTC
hm odd I cannot reproduce it. did you try to change the dpi on either machine to see whether that makes it work/breaks it? I.e. any clue how we could reproduce it?
Comment 2 peje66 2015-11-28 09:37:57 UTC
On 2015-11-28 01:18, Milian Wolff via KDE Bugzilla wrote:
> https://bugs.kde.org/show_bug.cgi?id=355960
>
> --- Comment #1 from Milian Wolff <mail@milianw.de> ---
> hm odd I cannot reproduce it. did you try to change the dpi on either machine
> to see whether that makes it work/breaks it? I.e. any clue how we could
> reproduce it?
>
I'll try to test some more when I'm back at work on monday.
Comment 3 peje66 2015-11-30 06:59:23 UTC
At work on the 108 dpi monitor:
Using "System Settings->Fonts" to force a lower dpi , in this case 96, the splash looks fine.
Comment 4 peje66 2015-11-30 16:19:47 UTC
At home on the 90 dpi monitor:
Using "System Settings->Fonts" to force a higher dpi , in this case 110dpi , the splash looks wrong.
Comment 5 Milian Wolff 2015-12-01 18:44:49 UTC
What Qt version are you running? Maybe I cannot reproduce this b/c I'm using Qt 5.5?

Or can you reproduce this by forcing 110dpi and running

qmlscene path/to/kdevelop/app/splash.qml

I can even increase it to 140 and it still looks good... Quite frankly, I have no clue what's going on here...
Comment 6 peje66 2015-12-01 22:35:35 UTC
Using qmlscene it looks good. 
I edited splash.qml and changed the initial version from 2.0.0 to 4.90.90, then kdevelop also shows the whole string correct, even at 140 dpi.

It's as if the splash window is scaled after the initial "Kdevelop 2.0.0" string and then is not resized when the correct version is set from splash.cpp.

Following patch fixes it for me:
diff --git a/app/splash.qml b/app/splash.qml
index dd6562c..3c08cba 100644
--- a/app/splash.qml
+++ b/app/splash.qml
@@ -30,9 +30,9 @@ Rectangle {
 
     property int progress: 50
     property url appIcon
-    property string appVersionMajor: "2"
-    property string appVersionMinor: "0"
-    property string appVersionPatch: "0"
+    property string appVersionMajor: "4"
+    property string appVersionMinor: "90"
+    property string appVersionPatch: "90"
 
     // color for the non-colored rectangles
     readonly property string defaultColor: "#3E3E3E"

It's just a minor visual bug which should go away when you release 5.0.0.
Comment 7 Milian Wolff 2015-12-02 10:51:05 UTC
Git commit 4b8675394446070c2d7ccbbf710055ec3f3a3618 by Milian Wolff, on behalf of Pär-Ola Nilsson.
Committed on 02/12/2015 at 10:50.
Pushed by mwolff into branch '5.0'.

Fix size of splash screen on high-dpi configurations.

M  +3    -3    app/splash.qml

http://commits.kde.org/kdevelop/4b8675394446070c2d7ccbbf710055ec3f3a3618
Comment 8 Milian Wolff 2015-12-02 10:51:24 UTC
thanks for figuring this out, much appreciated