Bug 355652 - double entry for spell checking language
Summary: double entry for spell checking language
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: inputline (show other bugs)
Version: frameworks
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-20 18:05 UTC by Christian (Fuchs)
Modified: 2016-07-19 14:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the issue (47.91 KB, image/png)
2015-11-20 18:07 UTC, Christian (Fuchs)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2015-11-20 18:05:58 UTC
With recent changes in ... I guess frameworks, the input field has a language entry in the context menu by default. With konversation adding its own, there are now two entries for choosing the spell checking language.

Reproducible: Always

Steps to Reproduce:
1. Have the most recent versions of framework, plasma and whatnot
2. Open konversation
3. Right click the text input box

Actual Results:  
See screenshot

Expected Results:  
One is sufficient

I like turtles.
Comment 1 Christian (Fuchs) 2015-11-20 18:07:31 UTC
Created attachment 95620 [details]
Screenshot of the issue
Comment 2 Sudhir Khanger 2015-12-07 19:06:12 UTC
I think it would be a good idea to remove spell check options from Konversation and follow whatever is set in SystemSettings.
Comment 3 Eike Hein 2015-12-07 19:12:17 UTC
No, we added the submenu on user request because users want per-channel language settings.
Comment 4 Christian (Fuchs) 2015-12-07 19:16:00 UTC
(In reply to Sudhir Khanger from comment #2)
> I think it would be a good idea to remove spell check options from
> Konversation and follow whatever is set in SystemSettings.

Great idea, please also remove them from kmail, kate and calligra and libreoffice while at it, no need for them there either. 

Jokes aside: there are lots of people, me included, who speak multiple languages and thus write and read in multiple languages. Similar to why you need this option in the above mentioned applications, you definitely need them in konversation, and you need them by channel. I'm glad that frameworks seem to now offer this by default on text input fields, so for people with a version recent enough simply only that one should be shown, and for people with older versions the current solution should still be available.
Comment 5 Eike Hein 2016-07-19 14:40:02 UTC
Fixed in cab6d75a3a56