Created attachment 95615 [details] Fix InPlace is declared in a #if-endif, but used in a few places outside the ifs. #if LLVM_VERSION_MAJOR == 3 && LLVM_VERSION_MINOR <= 6 bool InPlace; #endif I've attached a fix that defines a SUPPORTS_IN_PLACE macro and uses it wherever InPlace is mentioned.
Are you on llvm 3.5 ?
Yes, well, I was. I updated to 3.8 (trunk) after reporting this. Anyhow - either ifdef all, or none and require a newer llvm - this way, it is confusing :)
Git commit ef683ba410b2a6f20609700ca6915a28a434f1b4 by Sergio Martins. Committed on 20/11/2015 at 19:34. Pushed by smartins into branch 'master'. Add comments to clarify why we define the InPlace member M +2 -0 Lazy.cpp http://commits.kde.org/clazy/ef683ba410b2a6f20609700ca6915a28a434f1b4
I think there's a misunderstanding. bool InPlace is already defined with clang >= 3.7, only <= 3.6 doesn't have it. Your patch would make "InPlace = inplace;" never run on clang 3.7
Git commit 158738cb366383e8ef09703c509c0318cdd3f736 by Sergio Martins. Committed on 21/11/2015 at 10:14. Pushed by smartins into branch 'master'. Unbreak build on clang 3.6 Forgot to comment comment M +1 -1 Lazy.cpp http://commits.kde.org/clazy/158738cb366383e8ef09703c509c0318cdd3f736
Ok, I thought it was vice-versa. I'm closing since I'm unable to test with the original llvm version I had.