Bug 355508 - Make KAboutData accept https:// next to http:// for schema of homepage URL
Summary: Make KAboutData accept https:// next to http:// for schema of homepage URL
Alias: None
Product: frameworks-kcoreaddons
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Michael Pyne
Depends on:
Reported: 2015-11-17 18:30 UTC by Martin Walch
Modified: 2015-12-03 00:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.17


Note You need to log in before you can comment on or make changes to this bug.
Description Martin Walch 2015-11-17 18:30:41 UTC
API documentation says:

> Start the address with "http://".

and the implementation checks

> if (d->_homepageAddress.contains(QLatin1String("http://"))) {

Considering that more and more of the www is using https:// as primary schema, deprecating plain http://, this should be specified and processed accordingly in KAboutData.  (In particular also *.kde.org defaults to https://)
Comment 1 Michael Pyne 2015-11-27 23:16:38 UTC
A fix is in the works, see https://git.reviewboard.kde.org/r/126189/
Comment 2 Michael Pyne 2015-12-03 00:38:51 UTC
Git commit 9e5f731c8f63d239172f76d826973042e7920dee by Michael Pyne.
Committed on 03/12/2015 at 00:37.
Pushed by mpyne into branch 'master'.

KAboutData: Allow https:// and other URL schemas in homepage.

This commit permits URLs such as "https://www.foo.org" (i.e. with
non-http schemas), since we currently require applications to provide
a http:// URL only (a rather obvious misfeature in 2015).

M  +12   -0    autotests/kaboutdatatest.cpp
M  +22   -19   src/lib/kaboutdata.cpp
M  +14   -8    src/lib/kaboutdata.h