Bug 355412 - Missing icons for plasma-nm
Summary: Missing icons for plasma-nm
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Fedora RPMs Linux
: NOR major
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
: 355529 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-16 08:20 UTC by Jan Grulich
Modified: 2015-12-07 09:49 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Grulich 2015-11-16 08:20:39 UTC
After update to KF5 5.16 I spotted that there is no icon for VPN connections in plasma-nm.

Reproducible: Always
Comment 1 Jan Grulich 2015-11-16 08:41:43 UTC
Changing summary, VPN icon is not the only one missing, previously we had a bunch of icons for various modem technologies (edge, gprs, hdspa, etc.). 

And last thing, why all icons have red padlock while ethernet has it black, which is btw. barely visible.
Comment 2 andreas_k 2015-11-16 10:31:38 UTC
The main problem is that noone tell us to add additional icons for (edge, gprs, hdspa, ...) so if you know the icon name please list all missing icons by name. we will have a look about the visibility.
Comment 3 Jan Grulich 2015-11-16 10:49:34 UTC
They were all in previous release so you can check it there. I expected you did that before you replaced the old icon pack with the new one.
Comment 4 Jan Grulich 2015-11-16 11:05:40 UTC
Missing icons:
- network-mobile-[0, 20, 40, 60, 80, 100]-[gprs, edge, umts, hsdpa, hsupa, hspa, lte]
- network-mobile-[0, 20, 40, 60, 80, 100]-[gprs, edge, umts, hsdpa, hsupa, hspa]-locked
- network-mobile-on
- network-vpn
Comment 5 andreas_k 2015-11-16 11:06:21 UTC
thanks. we will fix it.
Comment 6 Benedikt Gollatz 2015-11-16 11:10:51 UTC
I'm experiencing the same problem with missing VPN icons. "kiconfinder5 network-vpn" only finds a 22x22 version of the icon.

The modem icons Jan is speaking of are

network-mobile-%1
network-mobile-%1-gprs
network-mobile-%1-edge
network-mobile-%1-umts
network-mobile-%1-hsdpa
network-mobile-%1-hsupa
network-mobile-%1-hspa
network-mobile-%1-lte

where %1 can be 0, 20, 40, 60, 80, or 100. These are completely missing from my system (cannot be found by kiconfinder5).

I also noticed that the systray icon for Amarok is missing. kiconfinder points to a 48x48 version of the icon, which is coloured, unlike the black-and-transparent outline version of the symbol that was there before.
Comment 7 Uri Herrera 2015-11-16 11:50:55 UTC
The icons for plasma-nm come form the Plasma theme not the icon theme. And yes they are missing. I'll add them.
Comment 8 Uri Herrera 2015-11-17 03:48:39 UTC
I've added the icons but they don't have the class attribute so they won't change color when using another color scheme.
Comment 9 andreas_k 2015-11-17 08:31:19 UTC
I add marco to the bug report cause he knows the attribute stuff.
Comment 10 Jan Grulich 2015-11-17 12:20:26 UTC
Perfect, thanks, just add "network-mobile-on" icon.
Comment 11 Marco Martin 2015-11-17 17:34:00 UTC
is the latest version just pushed complete?
Comment 12 Jan Grulich 2015-11-17 19:56:28 UTC
Nope, one icon (network-mobile-on) is still missing.
Comment 13 Jan Grulich 2015-11-19 13:12:23 UTC
Found one more missing icon → network-wired (used for deactivated ethernet connections), you have only network-wired-[available, unavailable, activated, activated-locked, activated-limited].
Comment 14 Marco Martin 2015-11-19 14:29:52 UTC
hmm, how many icons are there? if it's became hard to even keep track of how many icons that single applet is using, isn't that a symptom of a too complicate design?
(perhaps using composed layers like the battery applet would greatly reduce the sheer quantity of individual icons needed)
Comment 15 Jan Grulich 2015-11-19 14:47:27 UTC
We use quite a lot of icons, because there is also quite a lot of connection types, where some of them can have different signal/technology/state. It's true that most of them could be created from various layers, but right now I don't have time to do that.
Comment 16 Jan Grulich 2015-11-29 15:33:08 UTC
Ping? Any progress on adding those two missing icons (network-wired, network-mobile-on)? You have just a week or so to get this into KF5 5.17, otherwise it will be broken for users one more month.
Comment 17 andreas 2015-12-06 11:47:13 UTC
was included with this commit (https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=e73a82c168ed2e4c16d6b773c8fd33f693c1f9c2)

please check plasma-framework master
Comment 18 andreas 2015-12-06 11:57:04 UTC
*** Bug 355529 has been marked as a duplicate of this bug. ***
Comment 19 Jan Grulich 2015-12-06 17:29:27 UTC
Perfect, the set is now complete, but unfotrunately broken for breeze-dark because it requires to set some attribute or something like that as Uri said in comment 8.
Comment 20 Marco Martin 2015-12-07 09:45:48 UTC
should be fixed now
Comment 21 Jan Grulich 2015-12-07 09:49:08 UTC
Yes, it's fixed finally \o/. Maybe we should ask for a new tarball of plasma-framework which includes this fix.