Bug 355310 - Setting Custom Icon for Places Entry Impossible Due to Forced Window Focus
Summary: Setting Custom Icon for Places Entry Impossible Due to Forced Window Focus
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kiconthemes
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Christoph Feck
URL:
Keywords:
: 357533 359362 360579 364349 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-11-13 20:46 UTC by andydecleyre
Modified: 2017-12-20 14:55 UTC (History)
15 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Video Demonstration (1.11 MB, video/x-matroska)
2015-11-13 20:50 UTC, andydecleyre
Details
xprop and xwinfo output for the three dialogs (139.99 KB, text/plain)
2016-01-18 20:33 UTC, Frank Reininghaus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andydecleyre 2015-11-13 20:46:58 UTC
The available versions are way off. This is regarding dolphin 15.08.3.

I have added a custom entry to the places panel. I right-click it, hit "Edit" and click the icon to change it. The icon selector appears, so I click "Other icons" and "Browse."

The new file chooser window is stuck behind all other dolphin windows. I can move it around (behind the others), but I can't focus or raise it. Single clicking on folders does nothing, and double clicking selects a folder, but can do nothing else.

I will attach a short video demonstration.

Reproducible: Always

Steps to Reproduce:
1. Right click places panel
2. Click "Add Entry"
3. Click the icon
4. Click "Other icons"
5. Click Browse
6. Try to select an icon. I dare you.

Actual Results:  
Repeated from Details:

The new file chooser window is stuck behind all other dolphin windows. I can move it around (behind the others), but I can't focus or raise it. Single clicking on folders does nothing, and double clicking selects a folder, but can do nothing else.

Expected Results:  
The window should have allowed focus and control, so that a user could choose an icon file to use.

kwin 5.4.3
Comment 1 andydecleyre 2015-11-13 20:50:25 UTC
Created attachment 95486 [details]
Video Demonstration
Comment 2 Frank Reininghaus 2015-11-16 22:13:04 UTC
Thanks for the bug report.

(In reply to andydecleyre from comment #0)
> The available versions are way off. This is regarding dolphin 15.08.3.

Yes, you are right - sorry about that. I have just created the missing versions.
Comment 3 Gunnar Grim 2015-12-29 17:44:46 UTC
I also ran into this bug on SuSE Leap 42.1 with Plasma 5.
Comment 4 Gunnar Grim 2015-12-29 17:48:31 UTC
Workaround:

1) Add a "Place".
2) Edit ~/.local/share/user-places.xbel
3) Enter the path in the name attribute of the bookmark:icon element in the bookmark element for the place. Example:

<bookmark:icon name="/home/gugrim/projects/Klara/trunk/docs/KlaraLogo.svg"/>
Comment 5 andydecleyre 2016-01-07 22:49:56 UTC
Thank you Gunnar Grim!
Comment 6 Soukyuu 2016-01-09 22:08:05 UTC
Still happens with 15.12
Comment 7 Frank Reininghaus 2016-01-14 23:39:20 UTC
This is a bug in the KIconThemes framework (note that it's also reproducible in the file dialog of, e.g., KWrite). It forces the dialogs to be non-modal, so they do not work properly because the grand parent of the "Browse..." dialog is modal.

I have uploaded a patch for review that fixes the problem for me:

https://git.reviewboard.kde.org/r/126750/
Comment 8 Frank Reininghaus 2016-01-18 20:33:57 UTC
Created attachment 96718 [details]
xprop and xwinfo output for the three dialogs

Martin said in the review request that xprop and xwinfo output for the three windows (the modal "Add Entry" dialog, the dialog for choosing the icon, and the file dialog for choosing the actual file) are needed. I generated it by pasting the commands below into a shell and clicking the three windows twice each and attached it here. I hope it helps!

echo "xprop for modal \"Add Entry\" dialog" > bug355310.txt
echo >> bug355310.txt
xprop >> bug355310.txt
echo >> bug355310.txt
echo "xwininfo for modal \"Add Entry\" dialog" >> bug355310.txt
echo >> bug355310.txt
xwininfo >> bug355310.txt
echo >> bug355310.txt
echo "xprop for \"Choose Icon\" dialog" >> bug355310.txt
echo >> bug355310.txt
xprop >> bug355310.txt
echo >> bug355310.txt
echo "xwininfo for \"Choose Icon\" dialog" >> bug355310.txt
echo >> bug355310.txt
xwininfo >> bug355310.txt
echo >> bug355310.txt
echo "xprop for file dialog for choosing the icon" >> bug355310.txt
echo >> bug355310.txt
xprop >> bug355310.txt
echo >> bug355310.txt
echo "xwininfo for file dialog for choosing the icon" >> bug355310.txt
echo >> bug355310.txt
xwininfo >> bug355310.txt
Comment 9 Christoph Feck 2016-02-14 03:40:03 UTC
*** Bug 359362 has been marked as a duplicate of this bug. ***
Comment 10 Christoph Feck 2016-03-10 18:57:59 UTC
*** Bug 357533 has been marked as a duplicate of this bug. ***
Comment 11 Dick Tracey 2016-03-13 01:43:26 UTC
I can confirm that this still happens on Arch Linux, with Dolphin 15.12.2
Comment 12 Christoph Feck 2016-03-15 22:43:24 UTC
*** Bug 360579 has been marked as a duplicate of this bug. ***
Comment 13 tickferno 2016-07-12 18:04:41 UTC
I can confirm this on Kubuntu 16.04
Comment 14 foss 2017-03-17 14:00:35 UTC
I don't know exactly when this got fixed but since a while the bug is not present any more.

From about menu:
Dolphin 16.12.3
KDE Frameworks 5.32.0
Qt 5.8.0 (built against 5.8.0)
Comment 15 Christoph Feck 2017-12-20 14:54:15 UTC
Indeed. Could not find the commit, though.
Comment 16 Christoph Feck 2017-12-20 14:55:00 UTC
*** Bug 364349 has been marked as a duplicate of this bug. ***