Bug 355044 - Sending a file to a device should also show progress
Summary: Sending a file to a device should also show progress
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Erik Duisters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-08 17:09 UTC by Kai Uwe Broulik
Modified: 2018-11-26 17:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2015-11-08 17:09:19 UTC
When receiving a file from a phone I get a progress indicator and the ability to cancel the transfer. Sending files to the phone shows a progress bar on the device but not on the computer.

Reproducible: Always

Steps to Reproduce:
1. Send a large file to the phone
2.
3.

Actual Results:  
No indication what's going on, except on the phone

Expected Results:  
A progress indicator appears in system tray like it does when copying files or receiving files from the phone.
Comment 1 Aleix Pol 2015-11-12 01:56:18 UTC
The information is being passed already. We'd need a way to reproduce.
Comment 2 Kai Uwe Broulik 2015-11-12 07:55:19 UTC
Umm, sending the large file to the phone should be it? Or what kind of means to reproduce are you referring to?
Comment 3 Albert Vaca Cintora 2015-11-12 14:48:23 UTC
Indeed, there is no progress bar when sending a file (there is one only when receving), reopening.
Comment 4 Erik Duisters 2018-11-26 17:33:05 UTC
Git commit 2c9fde483ad109ab4e4dba293640ba55ddad24f7 by Erik Duisters.
Committed on 26/11/2018 at 17:32.
Pushed by eduisters into branch 'master'.

Show progress when sending a file from desktop

Summary:
Show progress when sending a file from the desktop

Test Plan:
Complete transfer:
-Right click on a big file in dolphin
-Select Send to xx via KDE Connect
-Open the Notifications widget and verify progress is shown correctly

Stop transfer:
-Right click on a big file in dolphin
-Select Send to xx via KDE Connect
-Open The Notifications widget and press the stop/kill button
-Observe that the file upload is stopped

Reviewers: #kde_connect, nicolasfella

Reviewed By: #kde_connect, nicolasfella

Subscribers: apol, broulik, nicolasfella, kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16279

M  +1    -0    core/CMakeLists.txt
M  +6    -1    core/backends/lan/landevicelink.cpp
M  +65   -18   core/backends/lan/uploadjob.cpp
M  +10   -0    core/backends/lan/uploadjob.h

https://commits.kde.org/kdeconnect-kde/2c9fde483ad109ab4e4dba293640ba55ddad24f7