Bug 354756 - Checkbox theming approach prevents implementation of Breeze checkbox design
Summary: Checkbox theming approach prevents implementation of Breeze checkbox design
Status: CLOSED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-02 22:23 UTC by Andrew Lake
Modified: 2018-03-25 17:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lake 2015-11-02 22:23:13 UTC 
The current approach that renders a button background and the checkmarks.svg element on top of the button.svg background makes it challenging to implement the Breeze checkbox design in the plasma theme (the checkbox background is different from the button background).

One possible backward compatible solution might be to define new elements in checkmarks.svg that allow the theme to specify the full visuals for the checkbox in one place.

Reproducible: Always
Comment 1 Marco Martin 2015-11-19 10:09:40 UTC 
still valid? even tough the button graphics is still used, it looks pretty near in the latest version
Comment 2 Marco Martin 2016-02-17 10:04:43 UTC 
marking as "close enough"