Bug 354715 - With KF5, KLineEdit should not be unconditionally preferred over QLineEdit
Summary: With KF5, KLineEdit should not be unconditionally preferred over QLineEdit
Status: RESOLVED FIXED
Alias: None
Product: krazy
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Allen Winter
URL: https://git.reviewboard.kde.org/r/125...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-02 00:02 UTC by Martin Walch
Modified: 2015-11-16 19:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Walch 2015-11-02 00:02:41 UTC
Krazy  complains about the use of QLineEdit namedialog.ui from lskat:

> Check for Qt classes that should not be used [qclasses]... 2 issues found
>         ./namedialog.ui: Use KLineEdit instead of QLineEdit line#35
>         ./namedialog.ui: Use KLineEdit instead of QLineEdit line#38
>         Don't use Qt 4 classes that are deprecated. Additionally make sure
>         to use the KDE version of some Qt GUI elements to provide a
>         consistent look and feel for the KDE desktop. The KDE classes are
>         not just adding functionalities to the Qt base class and are mostly
>         not even based on the Qt class.
>         <http://techbase.kde.org/Policies/API_to_Avoid> *Please* *refer*
>         *to* *the* *API* *documentation* *for* *details* *before* *porting*
>         *to* *the* *K* *classes*.

But with KF5 this is not generally true any more (see comments on reviewboard). The  "Porting Notes" actually encourage the use of QLineEdit where the additional functionality of KLineEdit is not needed. (https://community.kde.org/Frameworks/Porting_Notes#General_2)
Comment 1 Allen Winter 2015-11-03 17:48:10 UTC
fixed.  please give the EBN a day or 2 to catchup on this change.
Comment 2 Martin Walch 2015-11-16 19:49:18 UTC
Thanks.