Bug 354513 - drop comment field from "new User ID" dialog and from OpenPGP Certificate Creation Wizard
Summary: drop comment field from "new User ID" dialog and from OpenPGP Certificate Cr...
Status: RESOLVED FIXED
Alias: None
Product: kleopatra
Classification: Applications
Component: general (show other bugs)
Version: git master
Platform: Compiled Sources All
: NOR normal
Target Milestone: ---
Assignee: Andre Heinecke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-28 16:34 UTC by Daniel Kahn Gillmor
Modified: 2017-07-05 14:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kahn Gillmor 2015-10-28 16:34:11 UTC
Kleopatra exposes a "Comment" field when creating new OpenPGP certificates, and when adding a new User ID.    Please do not expose it to normal users.

There are very few people who legitimately need this Comment field, and those people can use the command line or some expert mode. In practice, the presence of this field encourages people to fill it in with information that is at best useless clutter.

For more rationales why, see: https://www.debian-administration.org/users/dkg/weblog/97 

Reproducible: Always
Comment 1 Andre Heinecke 2015-10-28 16:48:40 UTC
I agree. As GnuPG 2.1 stopped asking for a comment by default Kleopatra should do so, too.
Comment 2 Andre Heinecke 2016-04-08 17:06:07 UTC
It's on my todo for 16.10 but working on this dialog I would like to replace the comment field by the option to add more then one e-mail address. But the current GnuPG batch keygen API does not offer this :-/

(See https://bugs.gnupg.org/gnupg/issue2280 )
Comment 3 Andre Heinecke 2017-07-05 14:51:04 UTC
Git commit 7c143754d14f29fe1553f82f38df46a46aa97d73 by Andre Heinecke, on behalf of Justus Winter.
Committed on 05/07/2017 at 14:50.
Pushed by aheinecke into branch 'master'.

Remove comment field from OpenPGP key generation

The comment part of OpenPGP user ids is nowadays seen as a misfeature.
There is no consensus about what kind of information to put there, and
worse, users may not be aware that this information is published as
part of the certificate.

Some more rationale for this can be found under:
https://debian-administration.org/users/dkg/weblog/97
Differential: D6416

Signed-off-by: Justus Winter <justus@gnupg.org>

Commit message slightly amended by
Andre Heinecke <aheinecke@intevation.de>

M  +0    -17   src/newcertificatewizard/enterdetailspage.ui
M  +3    -27   src/newcertificatewizard/newcertificatewizard.cpp

https://commits.kde.org/kleopatra/7c143754d14f29fe1553f82f38df46a46aa97d73