Bug 354330 - Renaming a file does not scroll to the selected file
Summary: Renaming a file does not scroll to the selected file
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (show other bugs)
Version: 17.08.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-25 01:29 UTC by Nathan Shearer
Modified: 2020-10-28 22:21 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Video (568.19 KB, video/mp4)
2020-10-27 22:04 UTC, Justin Zobel
Details
reproducible with files located in a ntfs partition (1.47 MB, video/webm)
2020-10-28 10:49 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Shearer 2015-10-25 01:29:12 UTC
This is a regression that was fixed years ago and has resurfaced again. I could not find the original closed bug to re-open it.

In a folder with lots of files (like your music folder), rename a file so it's new name causes it to be resorted outside the current scroll or view. The window should automatically scroll to show the already-selected renamed file, but it doesn't. If you immediately press up then down on your keybaord it will auto-scroll and show the renamed file.

Reproducible: Always
Comment 1 Nathan Shearer 2017-03-03 16:22:31 UTC
Still exists in Dolphin 16.08.3
Comment 2 Patrick Silva 2017-03-05 00:40:57 UTC
Annoying usability problem...
Comment 3 Nate Graham 2017-09-04 04:26:04 UTC
There are lots of legit usability reasons why you might *not* want this. For example, if you're renaming multiple files in such a manner that they will be re-sorted elsewhere, after each one your view will change, making the multiple-file-rename operation an infuriating experience. macOS finder behaved this way for many years and Apple got a lot of complaints about it, eventually reverting the behavior to match what Dolphin does today.
Comment 4 Nate Graham 2017-09-04 04:54:28 UTC
FWIW, there is a patch for this: https://phabricator.kde.org/D6312
Comment 5 Elvis Angelaccio 2017-09-04 08:02:58 UTC
Reopening, this should be properly discussed before a wontfix. (see my comment in D6312)
Comment 6 Nate Graham 2017-09-04 12:53:55 UTC
Fair enough, I withdraw my objection.
Comment 7 Elvis Angelaccio 2017-09-17 09:18:03 UTC
Git commit 478f404b8abf924a0e3e21bbf1dd49aefbe47672 by Elvis Angelaccio, on behalf of Emirald Mateli.
Committed on 17/09/2017 at 09:12.
Pushed by elvisangelaccio into branch 'Applications/17.08'.

Keep renamed file(s) in view

When renaming a file, if its new name causes it to scroll out of view,
Dolphin will not scroll to the location of the new file.
This patch aims to address that. This affects all view modes.

Test Plan:
1. Have many files in a directory (or several files, just zoom in a lot)
2. Rename a file so that it will move out of view

Differential Revision: https://phabricator.kde.org/D6312

M  +19   -3    src/views/dolphinview.cpp
M  +9    -0    src/views/dolphinview.h
M  +9    -0    src/views/renamedialog.cpp
M  +4    -0    src/views/renamedialog.h

https://commits.kde.org/dolphin/478f404b8abf924a0e3e21bbf1dd49aefbe47672
Comment 8 Elvis Angelaccio 2017-09-17 09:20:06 UTC
I'm leaving this bug open because there is still a corner case not fixed by the above patch:

1. rename something so that it goes out of the view
2. dolphin scrolls the view
3. press CTRL+Z
4. dolphin should scroll the view back to the original place but it doesn't.
Comment 9 null 2017-11-16 13:46:34 UTC
Ideas for a potential patch: https://phabricator.kde.org/D6312#146843
Comment 10 Justin Zobel 2020-10-25 00:45:27 UTC
I cannot reproduce on Dolphin 20.08.1, can you please re-test and confirm if this is still an issue.
Comment 11 Patrick Silva 2020-10-27 11:46:58 UTC
I can reproduce with any view mode on neon unstable.
Comment 12 Justin Zobel 2020-10-27 22:04:42 UTC
Created attachment 132812 [details]
Video

Interesting that we're both on KDE Neon Unstable but I can't reproduce. Must be a setting or configuration option somewhere.
Comment 13 Patrick Silva 2020-10-28 10:49:13 UTC
Created attachment 132830 [details]
reproducible with files located in a ntfs partition

Weirdly I can reproduce this bug with files located in my ntfs partition
but I can't with the ones located in my Home.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.0
Comment 14 Nate Graham 2020-10-28 14:12:07 UTC
Info was provided; moving back to REPORTED
Comment 15 Justin Zobel 2020-10-28 22:21:35 UTC
Can confirm with NTFS partition that it does not scroll to newly named file.