Bug 353933 - Build fails with sqlite < 3.8.3 due to use of SQLITE_DETERMINISTIC
Summary: Build fails with sqlite < 3.8.3 due to use of SQLITE_DETERMINISTIC
Status: CLOSED FIXED
Alias: None
Product: KEXI
Classification: Applications
Component: KexiDB (show other bugs)
Version: 2.9.8
Platform: Other Linux
: NOR normal
Target Milestone: 2.9.9
Assignee: Jarosław Staniek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-15 18:48 UTC by Rex Dieter
Modified: 2015-10-15 20:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.9.9
Sentry Crash Report:


Attachments
possible fix (759 bytes, patch)
2015-10-15 19:12 UTC, Jarosław Staniek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rex Dieter 2015-10-15 18:48:49 UTC
Recent commit
http://commits.kde.org/calligra/d09d012b470df192214524326a3b8444c51daac6
for bug #352631 

introduces usage of sqlite constant SQLITE_DETERMINISTIC which is available only in sqlite-2.8.3 (and newer), according to:
http://www.sqlite.org/changes.html

This breaks building on systems with older sqlite versions, like Red Hat Enterprise 7 (which currently ships sqlite-3.7.17)

Reproducible: Always
Comment 1 Jarosław Staniek 2015-10-15 19:01:27 UTC
I think it's about 3.8.3 not 2.8.3 :)
Comment 2 Jarosław Staniek 2015-10-15 19:09:25 UTC
Thanks!
Comment 3 Jarosław Staniek 2015-10-15 19:12:34 UTC
Created attachment 95008 [details]
possible fix

Would you be able to try the patch on your own while preparing the package?
If you confirm it works for you it can be part of 2.9.9.
Comment 4 Rex Dieter 2015-10-15 19:44:38 UTC
Will do
Comment 5 Rex Dieter 2015-10-15 20:10:30 UTC
Thanks, that patch works as advertised.  SHIP IT
Comment 6 Jarosław Staniek 2015-10-15 20:18:05 UTC
Git commit a621f12b9052ca3c98dde058402fc2058a4d92e9 by Jaroslaw Staniek.
Committed on 15/10/2015 at 20:12.
Pushed by staniek into branch 'calligra/2.9'.

Kexi: Fix build when SQLite < 3.8.3 is used

This is due to use of SQLITE_DETERMINISTIC by the new SQL functions introduced in 2.9.8.
SQLITE_DETERMINISTIC is available since SQLite 3.8.3.

Big thanks to Rex Dieter.
FIXED-IN:2.9.9

M  +5    -1    libs/db/drivers/sqlite/sqlitefunctions.cpp

http://commits.kde.org/calligra/a621f12b9052ca3c98dde058402fc2058a4d92e9