Bug 353912 - Plastik window decoration, maximized, konsole text unreadable - no left padding, margin or border
Summary: Plastik window decoration, maximized, konsole text unreadable - no left pad...
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: unspecified
Platform: Mint (Ubuntu based) Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 22:29 UTC by Russell
Modified: 2016-10-29 19:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Need an option to have borders on maximized windows. (51.58 KB, image/jpeg)
2016-10-28 22:56 UTC, Russell
Details
Plastik window borders (94.28 KB, image/jpeg)
2016-10-29 04:04 UTC, Russell
Details
"Display Window Borders When Maximized" for Plastik in KDE5 (42.11 KB, image/jpeg)
2016-10-29 16:52 UTC, Russell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Russell 2015-10-14 22:29:33 UTC
There is a patch for the plastik Window Decorations at the bottom of bug 324011:

  "patch to keep plastik borders on maximized windows"
  https://bugs.kde.org/show_bug.cgi?id=324011

It fixes a UI problem which showed up more so in Konsole.  It happens with all windows, but it is more noticeable with Konsole because there are no other objects on the left hand side and text abuts the frame. Note:  There is a typo: maximizedBrders.setBorders(40)

When I maximize Konsole the first characters on the left are difficult to read and information could be missed. I am using "Linux Colors" which has a black background. My monitors are black and there just isn't enough visual separation. The rightside has the vertical scrollbar.

My first solution was to create a stylesheet:

  QWidget {
    padding: 0 0 4px 4px;
  }

  QTabBar::tab:selected {
    font: bold;
  }

And modify the desktop file:

  konsole -stylesheet DIR/.config/konsole/style.css

My second solution was to apply a patch similar to BUG 324011. I did not install it in ~/.kde/share/apps/kwin but instead /usr/share/kde4/apps/kwin/decorations/kwin4_decoration_qml_plastik/contents/ui because all users require it.



Reproducible: Always

Steps to Reproduce:
1. Double click the title to Maximize Konsole. 
2. View the left sign and see how close the Konsole text is to the left sign almost blending into the physical monitor frame.


Expected Results:  
Require visual separation between a window's output text and the desktop backup and/or physical monitor. The plastik patch in bug 324011 has the fix to provide this visual separation. The window border when windows are maximized provides UI consistency, improves readability, and visual separation.

Provide
Comment 1 Martin Flöser 2016-10-28 19:34:28 UTC
sorry for the very late response.

Somehow I don't really understand the issue you are describing. Could you please attach a screenshot highlighting the issue?
Comment 2 Russell 2016-10-28 22:56:48 UTC
Created attachment 101867 [details]
Need an option to have borders on maximized windows.

A - Konsole restored without CSS
B - Konsole restored with CSS
C - Konsole maximized without CSS  <-- *
D - Konsole maximized with CSS
E - A closer look at C             <-- *

* This is the problem. Borders are now gone when a window is maximized. I don't think CSS is the answer, because it affects all windows. When maximized the text is so close to the edge that it is very difficult to read (thus increasing the chances for error), especially if there is a lot of data (i.e., hex dump). I need the window to look like A at all times, whether maximized or restored.

Bottom line: Need an option to have borders on maximized windows.  This is how it use to work.
Comment 3 Christoph Feck 2016-10-29 00:07:23 UTC
Your screen shots do not show the Plastik decoration, but the Breeze decoration.

Please check if systemsettings5 > Application Style > Window Decorations > Breeze config > General tab > Display window borders for maximized windows resolves your issue.
Comment 4 Russell 2016-10-29 04:04:14 UTC
Created attachment 101870 [details]
Plastik window borders

Sorry about that. I have multiple versions of KDE. 

===> konsole --version
Qt: 4.8.6
KDE Development Platform: 4.14.2
Konsole: 2.14.2

===> konsole --version
Qt: 5.5.1
KDE Frameworks: 5.21.0
Konsole: 15.12.3

I took the screenshots from KDE 5. Please see the second image for Plastik. 

It is good to know that Breeze has the option to "Display window borders for mazimized windows". I do use Plastik.

KDE 4.14 which is my main/production desktop has the patch on from bug #324011 (see comment #32) which gives me consistent window borders --- restore or maximized. I can more easily see the first couple of characters... without the border the characters just fall into the black edges of the monitor.

KDE 5.21 still has the problem. Evidently the patch didn't make it to KDE 5?? I applied the original patch to /usr/share/kde4/apps/kwin/decorations/kwin4_decoration_qml_plastik/contents/ui/main.qml. There is a switch statement that contains a statement "maximizedBorders.setBorders(3);" for each of the cases.

I don't have the system anymore, but I had upgraded from an earlier version of KDE 4 around 2015-09, which had the window border when maximized.
Comment 5 Martin Flöser 2016-10-29 13:14:18 UTC
For the version of Breeze this seems to work fine as there are config options -> resolved worksforme.

In case of KDE 4: sorry, that's no longer maintained. We don't do any further bug fix releases and won't do any code changes any more.
Comment 6 Russell 2016-10-29 16:52:28 UTC
Created attachment 101881 [details]
"Display Window Borders When Maximized" for Plastik in KDE5

What about "Display Window Borders When Maximized" for Plastik in KDE5?
Comment 7 Martin Flöser 2016-10-29 18:36:01 UTC
> What about "Display Window Borders When Maximized" for Plastik in KDE5?

is it a wontfix. That won't be added to it. This is a very special request and is completely covered by Breeze. We don't need to support any possible feature in any theme.

For what is worth to mention: the code is QML, you can adjust yourself:
https://quickgit.kde.org/?p=kwin.git&a=blob&h=ce29dc1ae2ba8a9c2e5b13962d46d89ef2f23e6f&hb=54ca4a9b559d189eda11f0d1b1641cdc742b1e28&f=plugins%2Fkdecorations%2Faurorae%2Fthemes%2Fplastik%2Fpackage%2Fcontents%2Fui%2Fmain.qml#l417

just add there another
maximizedBorders.setBorders(4);
Comment 8 Russell 2016-10-29 19:47:41 UTC
Ok. In Window Decorations Window. There are 2 themes available Plastik and Breeze. I use Plastik.

Per my original bug report (see #1). I'll try to continue to use the patch provided by BUG 324011, Comment #32. 
https://bugs.kde.org/show_bug.cgi?id=324011#c32