I'm using Trojita which can [1] use the systemwide icon theme for a network connectivity indicator. It's using the network-connect and network-disconnect icons, and on my 14" laptop screen with 1600x900px resolution, these two icons are almost indistinguishable from each other. I understand that you're fans of BW icons, so could you please at least make the distance between the two things in the "network-disconnect" a bit more pronounced, so that it really catches one's attention? [1] https://gerrit.vesnicky.cesnet.cz/r/498 Reproducible: Always
I can't find the icons you're referring to. There is network-wired-activated and network-wired-unavailable under devices/22. Did you mean those?.
> I can't find the icons you're referring to. There is network-wired-activated > and network-wired-unavailable under devices/22. https://quickgit.kde.org/?p=breeze.git&a=blob&h=f3e684db7d9eb20f70e425a69fe6b7c049d956c0&hb=bac5a554494ee5b6890b69e80114e2e465009809&f=icons%2Factions%2F24%2Fnetwork-connect.svg
Are these icons being used in the system tray? please don't use action icons in the system tray. The correct icons are in devices/22 (in case you want to use them in the system tray). The system tray uses 22 px icons too not 24 px, those are for GTK toolbars. If it's a toolbar button what does it do? I think would it be better to have a new icon for the action in that case.
This bugreport is not about icons from the system tray. I'm an author of an extragear app, Trojita. This application has to know about the network status, and can be told to connect/disconnect from the network, and to use a special mode when the network is "expensive" (data roaming outside of EU, for example). That's why there's a set of three actions in Trojita's menu and Trojita's toolbar for switching between vairous network profiles. Trojita is a Qt app, we do not use KF5 except for systemwide plugins which are installed into Qt5's shared plugin directory (kwindowsystemintegration, etc). Notably, we just use QIcon::fromTheme which only accepts an icon's name, not any other qualifier such as panel/action/device/whatever_else. The problem which I'm seeing is that Breeze provides two icons (see #1 for their names) which represent opposite concepts/states/actions, but whose visual appearance is very similar -- to an extent that they cannot be used as a reasonable indicator of a network state based on just a quick glance. My proposal is to modify at least one of these icons so that their difference is made visually clearer.
Git commit aff95e266f1f3e0162e11419443fbbdb615eb455 by Jan Kundrát. Committed on 01/10/2015 at 10:22. Pushed by gerrit into branch 'master'. GUI: Use Breeze's red icon from the Plasma panel when offline The icon is copied from breeze/status/panel/network-disconnect.svg because it's an icon which is a private thing intended to be used by the Plasma shell. I do not think that I can persuade the QIcon::fromTheme to use a particular icon from a particular directory. Change-Id: I1b3cf14a068d8aef2ff259fa0439e87d224da0a1 M +1 -0 src/icons.qrc A +104 -0 src/icons/breeze/network-disconnect.svg http://commits.kde.org/trojita/aff95e266f1f3e0162e11419443fbbdb615eb455
Jan, it's easier if you can include a screenshot for the designer people of the icon and where it's used.
Created attachment 94878 [details] Screenshot of the actions in question This is how these icons look next to each other.
can you please have a look at the up to date network mangager icons. does they fit you? or where you want to have a better icon?
Dear andreas, this bugreport is about icons which are provided by Breeze under the name of "network-connect" and "network-disconnect". Right now, they live in [1] and [2] in the breeze-icons git repo. These icons are what an application gets when calling QIcon::loadFromTheme("network-connect"), for example. Plasma might or might not use something else in its applets, but that's not relevant here -- I opened this bugreport because an application which happens to use the systemwide Breeze theme will get two very similar icons for opposite actions. [1] https://quickgit.kde.org/?p=breeze-icons.git&a=blob&h=ecdc0371f86e01b5386a79adae8a2aad8ae7365e&f=icons%2Factions%2F24%2Fnetwork-connect.svg&o=plain [2] https://quickgit.kde.org/?p=breeze-icons.git&a=blob&h=8a9a44f2daeb25145ecc4969806a81cb908085e8&f=icons%2Factions%2F24%2Fnetwork-disconnect.svg&o=plain
Git commit 65e6f73d56f2aaec672c34ed1896e0a394b30076 by andreas kainz. Committed on 31/05/2016 at 21:37. Pushed by andreask into branch 'master'. update disconnect network icon for bigger diference to conntected M +9 -1 icons-dark/actions/16/network-disconnect.svg M +9 -1 icons-dark/actions/22/network-disconnect.svg M +4 -1 icons-dark/actions/24/network-disconnect.svg M +8 -0 icons/actions/16/network-disconnect.svg M +8 -0 icons/actions/22/network-disconnect.svg M +3 -0 icons/actions/24/network-disconnect.svg http://commits.kde.org/breeze-icons/65e6f73d56f2aaec672c34ed1896e0a394b30076
Git commit e04eb26cad367ae987b6154eac1dde9d4c4a1603 by Jan Kundrát. Committed on 01/06/2016 at 08:20. Pushed by gerrit into branch 'master'. Remove network-disconnect override icon for Breeze Now that the Breeze icon theme got changed to better visualize the difference between the connected and disconnected states, there's no need to ship a custom override. Thanks, Andreas. Change-Id: Ifcc80a18d04cc7a63e30e709542fd95a202b9236 M +0 -1 src/icons.qrc D +0 -104 src/icons/breeze/network-disconnect.svg http://commits.kde.org/trojita/e04eb26cad367ae987b6154eac1dde9d4c4a1603