Bug 353180 - CMake global settings aren't saved
Summary: CMake global settings aren't saved
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: CMake (show other bugs)
Version: git master
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks: 355909
  Show dependency treegraph
 
Reported: 2015-09-25 15:39 UTC by Gleb Popov
Modified: 2015-12-02 21:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Popov 2015-09-25 15:39:26 UTC
CMake plugin settings doesn't seem to be saved into kdeveloprc when i click apply. They also aren't saved in memory, but that's a separate issue.

Other settings, including settings for, say, Qt Documentation plugin, are properly saved.

Reproducible: Always

Steps to Reproduce:
1. Open "KDevelop settings", go to the "CMake" tab.
2. Select "NMake makefiles".
3. Press "Ok"/"Apply".

Actual Results:  
After these steps kdeveloprc isn't written and when you open settings windows again, all changes are lost.
Comment 1 bungeman 2015-12-02 19:23:30 UTC
At least here on a recent build from git on Ubuntu Wily, the same thing happens with all of the 'Editor' configuration settings as well. No matter the modifications, the 'Apply' button is never activated, and no changes are applied.
Comment 2 Kevin Funk 2015-12-02 19:58:11 UTC
The "Editor" configuration settings thing is a different bug, solved in 5.0 branch.
Comment 3 Kevin Funk 2015-12-02 21:31:09 UTC
Git commit 91d7f8fc309ff0cc21a32ca7af1f510fe908fcd9 by Kevin Funk.
Committed on 02/12/2015 at 21:30.
Pushed by kfunk into branch '5.0'.

Make sure CMake settings are persisted

That was a matter of simply renaming the variables in the .ui to make
KConfig magic work
FIXED-IN: 5.0.0

M  +12   -18   projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp
M  +2    -2    projectbuilders/cmakebuilder/cmakebuildersettings.ui

http://commits.kde.org/kdevelop/91d7f8fc309ff0cc21a32ca7af1f510fe908fcd9