Bug 353171 - Loop playback doesn't work for certain videos embedded in PDF
Summary: Loop playback doesn't work for certain videos embedded in PDF
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.23.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL: https://git.reviewboard.kde.org/r/125...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-25 12:22 UTC by Arseniy Lartsev
Modified: 2021-07-24 00:32 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/okular/e9e5cb6317d2f46334dc624663b2999c1351f19c
Version Fixed In:

Attachments
Test case (226.26 KB, application/x-msdownload)
2015-09-25 12:26 UTC, Arseniy Lartsev 		Details
Source for the pdf (204.88 KB, application/zip)
2015-09-25 12:26 UTC, Arseniy Lartsev 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Arseniy Lartsev 2015-09-25 12:22:17 UTC 
Videos embedded by Latex movie15 package will always play once, regardless of the loop playback settings.

Patch: https://git.reviewboard.kde.org/r/125341/

Reproducible: Always
Comment 1 Arseniy Lartsev 2015-09-25 12:26:18 UTC 
Created attachment 94717 [details]
Test case
Comment 2 Arseniy Lartsev 2015-09-25 12:26:48 UTC 
Created attachment 94718 [details]
Source for the pdf
Comment 3 Albert Astals Cid 2015-09-26 15:30:23 UTC 
Git commit e9e5cb6317d2f46334dc624663b2999c1351f19c by Albert Astals Cid, on behalf of Arseniy Lartsev.
Committed on 26/09/2015 at 15:30.
Pushed by aacid into branch 'master'.

Repeat videos in PDFs automatically when needed

REVIEW: 125341

M  +13   -1    core/movie.cpp
M  +14   -2    core/movie.h
M  +6    -1    generators/poppler/generator_pdf.cpp
M  +16   -7    ui/videowidget.cpp

http://commits.kde.org/okular/e9e5cb6317d2f46334dc624663b2999c1351f19c
Comment 4 Paul 2015-10-24 17:46:24 UTC 
Don't know if anyone will see this as its resolved, but don't know where better to post this. it appears this commit was applied to an outdated version of generator_pdf.cpp.  There is one occurrence of 'Okular::Movie::playOnce' introduced in a recent commit (and behind an #ifdef HAVE_POPPLER_0_36), but playOnce was removed from the enum in this commit.
Comment 5 Albert Astals Cid 2015-10-26 18:41:30 UTC 
Paul, you're probably speaking about the unsupported frameworks branch, right?
Comment 6 Paul 2015-10-26 18:43:44 UTC 
Yes, apologies for forgetting to mention that.
Comment 7 Albert Astals Cid 2015-10-26 18:57:50 UTC 
Alex Merry fixed it this morning
Comment 8 Paul 2015-10-26 18:58:27 UTC 
Much appreciated :)