Bug 352988 - pressing Esc while renaming on folderview dismisses show the desktop effect
Summary: pressing Esc while renaming on folderview dismisses show the desktop effect
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop icons & Folder View widget (show other bugs)
Version: 5.4.1
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-21 14:05 UTC by Ralf Jung
Modified: 2017-09-06 08:51 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.11.0
Sentry Crash Report:


Attachments
xprop on plasma shell (55.49 KB, text/plain)
2015-09-29 13:32 UTC, Ralf Jung
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Jung 2015-09-21 14:05:22 UTC
I have "Show Desktop" tied to a shortcut, because I frequently want to interact with the widgets on the Desktop (in particular, with the Desktop folder view and the notes).

However, it often happens that after triggering "Show Desktop", when I click a widget, all windows re-appear. I frequently need 2-3 attempts to interact with the desktop widgets.

Reproducible: Sometimes

Steps to Reproduce:
1. Tie "Show Desktop" to a shortcut, or add the "Show Desktop" widget to the panel
2. Trigger "Show Desktop" via shortcut or widget.
3. Try interacting with widgets on the desktop (notes, a weather widget with a popup)

Actual Results:  
The "Show Desktop" effect ends, all windows re-appear.

Even when the weather widget works as intended, it is often the case that after closing the weather widget popup, clicking the notes widget makes all windows re-appear.

Expected Results:  
They should not re-appear. Instead, the weather popup should appear or the notes widget should get the focus.

 This is a huge regression compared to KDE4, where "Show Desktop" never failed me.
Comment 1 Marco Martin 2015-09-29 11:20:58 UTC
perhaps tied to the new show desktop effect, can't reproduce here tough
Comment 2 Martin Flöser 2015-09-29 12:07:54 UTC
Also just tried it: works as it should. I was able to open the add widget dialog add a widget, resize it, configure it, delete it again and all without show desktop ending.

@Ralf: what versions are you using and which distro? Recently we had some breakage by distros shipping a broken kwindowsystem causing desktop windows to not be marked as desktops.
Comment 3 Ralf Jung 2015-09-29 12:26:23 UTC
I'm using Plasma & Kwin 5.4.1 on Debian testing.

Maybe try adding a notes widget, and then see whether next time you "Show Desktop", you can click on it to type something? That's where I often see the bug; when I click the notes, all the windows come back up. This is not reproducible though.
Comment 4 Martin Flöser 2015-09-29 12:32:37 UTC
just done so and works fine. Can you please show we a dpkg -L of kwindowsystem?
Comment 5 Ralf Jung 2015-09-29 12:34:15 UTC
$ dpkg -L libkf5windowsystem5
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/libkf5windowsystem5
/usr/share/doc/libkf5windowsystem5/changelog.Debian.gz
/usr/share/doc/libkf5windowsystem5/copyright
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libKF5WindowSystem.so.5.14.0
/usr/lib/x86_64-linux-gnu/qt5
/usr/lib/x86_64-linux-gnu/qt5/plugins
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemWaylandPlugin.so
/usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemX11Plugin.so
/usr/lib/x86_64-linux-gnu/libKF5WindowSystem.so.5
Comment 6 Martin Flöser 2015-09-29 12:49:59 UTC
that seems correct now. Can you provide us the xprop of the desktop window?
Comment 7 Ralf Jung 2015-09-29 13:32:49 UTC
Created attachment 94775 [details]
xprop on plasma shell

Took me a few tries this time to reproduce the issue. I have that Norwegian weather widget and the notes on the desktop, and after opening and closing the weather widget popup, sometimes the cursor stops reacting to where on the plasma window it is - even when it is above the notes, it doesn't become that bar. If I now click, all the windows come back.

I used to also see this without opening the weather widget first, but not today.
Comment 8 Martin Flöser 2015-09-29 13:45:52 UTC
it's type desktop. So that's also fine.

If you are able to find a perfect way to trigger it, I hope we will be able to reproduce.
Comment 9 Gregor Mi 2015-10-19 19:47:34 UTC
Reproduced on Plasma 5.4.2, openSUSE 13.2.

There are some occasions where the windows reappear like try to draw a selection marquee. But that's not a reliable way to trigger it.

But this one:

1. Open some windows
2. Click Show Desktop widget
3. Select an item on the desktop
4. Right-click to rename
5. Cancel the action with ESC
6. ACTUAL: All windows reappear, EXPECTED: Rename operation gets cancelled

7. Show Desktop again and see that the item is still in rename mode.
Comment 10 Marco Martin 2015-10-28 14:54:23 UTC
last issue still happens, unrelated with the main bug
Comment 11 Eike Hein 2015-10-28 15:12:16 UTC
I don't see how I can influence that in any way in Folder?
Comment 12 Kai Uwe Broulik 2017-08-31 15:14:03 UTC
Git commit 55d74c68219781c8770b1a22ecd5155e9908ccb8 by Kai Uwe Broulik.
Committed on 31/08/2017 at 15:13.
Pushed by broulik into branch 'master'.

[DesktopView] Move cancelling showing desktop into keyPressEvent

This will route the event through the containment first which can then intercept it, e.g. to prevent
Escape from exiting showing desktop while renaming where it should only cancel that.

Differential Revision: https://phabricator.kde.org/D7630

M  +13   -11   shell/desktopview.cpp

https://commits.kde.org/plasma-workspace/55d74c68219781c8770b1a22ecd5155e9908ccb8
Comment 13 Kai Uwe Broulik 2017-09-06 08:51:56 UTC
Git commit 9646aec02c3b72d1bb74d89ed4ed86d9e93ce452 by Kai Uwe Broulik.
Committed on 06/09/2017 at 08:51.
Pushed by broulik into branch 'master'.

[Folder View] Accept and reject Escape event appropriately

When renaming, accept the Escape key event to prevent the containment from leaving Showing
Desktop mode. Otherwise don't accept it and let the containment do its thing.
FIXED-IN: 5.11.0

Differential Revision: https://phabricator.kde.org/D7631

M  +5    -1    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/9646aec02c3b72d1bb74d89ed4ed86d9e93ce452