Bug 352846 - Swap foreground and background color shortcut stops working
Summary: Swap foreground and background color shortcut stops working
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: unspecified
Platform: Other Other
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 353500 357454 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-17 15:29 UTC by sqdqsddd
Modified: 2016-01-12 07:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sqdqsddd 2015-09-17 15:29:20 UTC
From time to time, the Swap foreground and background color shortcut stops working.
After noticing the bug I added an alternate shortcut to see if only the default shortcut stopped working, but when the bug happens, neither work.
unfortunately, I couldn't pinpoint when the bug happens, it seems to be at random. sometimes I can draw for hours without a problem, sometimes it happens within 5 minutes. the only way to solve the problem is to close the active document and open it again. clicking on the small icon to change colors manually does work, just not the shortcut anymore.

I do the basic tasks with Krita (delete/create/group/move layers, draw/erase lines, select/deselect selections and delete what is inside them with the del key, zoom in/out and rotate/mirror the drawing), but even when trying to do all of those things, the bug doesn't happen.
I don't recall doing something else than these when the bug happens, so I can't be more precise on how to make it happen.

Reproducible: Couldn't Reproduce


Actual Results:  
shortcut to swap foreground and background color doesn't work

Expected Results:  
foreground and background color are swapped.

I don't remember this happening in version 2.9.6
This bug happens in both Windows (7 Ultimate SP 1) and Linux (Mint 17.1 and 17.2)
Comment 1 sqdqsddd 2015-09-17 15:42:12 UTC
I THINK it might be related to alt tabbing a lot.
on Linux Mint, I run a small virtual machine with windows 7 in it for some programs I need, and I noticed this bug seems to happen a lot more often on Linux than on Windows, especially when I alt tab from Krita to that VM.

I just tried alt tabbing a lot on W7, from Krita to other programs and program to program to Krita, and I still can't reproduce the bug so I can't confirm it is related to that though.
Comment 2 sqdqsddd 2015-09-18 00:56:52 UTC
Found the problem.
I had assigned the "move layer" shortcut to V, which is used by default to "activate line tool" in the "canvas input settings" of "configure Krita" under the settings tab (by default it is "left button + V")

Apparently, what I always thought was the normal behavior for the move tool was not correct (I had to hold V down or else it'd go back to the previously used tool, I used to use SAI a lot and it works like this there).

Here are the steps to reproduce the bug :
1. set the "move layer" shortcut to V
2. make sure the "activate line tool" shortcuts are the default ones (settings/configure Krita/Canvas input settings/tool invocation)
3. press V
X (swap foreground/background color shortcut by default, as well as the alternate shortcut) now stops working. I hope that helps.
Comment 3 JA12 2015-09-20 13:05:56 UTC
I can reproduce this too. Swap foreground and background colors (X) stops working after using the line tool with the shortcut (V).

Krita 2.9.7 from lime ppa, Ubuntu 14.04, Gnome 3 Classic, Nvidia graphics.
Comment 4 Halla Rempt 2015-09-21 08:13:49 UTC
Yes, I can confirm the issue. Thanks for the report!
Comment 5 sqdqsddd 2015-09-22 20:05:13 UTC
I'd like to add, the same thing happens when you set the line tool shortcut to R (which is already assigned to Select Layer Mode in settings/configure Krita/Canvas input settings/Select Layer/Layer Mode). so I assume the same thing problem would also occur when using the Y as shortcut (used in Exposure and Gamma/Exposure Mode).
Comment 6 Halla Rempt 2015-10-09 11:44:48 UTC
*** Bug 353500 has been marked as a duplicate of this bug. ***
Comment 7 wolthera 2016-01-04 19:48:05 UTC
*** Bug 357454 has been marked as a duplicate of this bug. ***
Comment 8 Halla Rempt 2016-01-11 15:19:18 UTC
This is the offending commit:

commit d7eca0f6cbac2bfe6ec8f201a4ad1ff5e8aa598f
Author: Dmitry Kazakov <dimula73@gmail.com>
Date:   Fri Jul 24 16:15:02 2015 +0300

    Fix a hangup when pressing 'v' and 'b' in the brush tool simultaneously
    
    CCBUG:350280
Comment 9 Halla Rempt 2016-01-12 07:50:53 UTC
Git commit 978503959238dc9bbb6bb6378e33d7315d629347 by Boudewijn Rempt.
Committed on 12/01/2016 at 07:48.
Pushed by rempt into branch 'rempt-osx-port'.

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_line.cc

http://commits.kde.org/krita/978503959238dc9bbb6bb6378e33d7315d629347
Comment 10 Halla Rempt 2016-01-12 07:51:42 UTC
Git commit ef6bae61b1ad6330e64e7d3f9e3168874c9c1bf8 by Boudewijn Rempt.
Committed on 12/01/2016 at 07:51.
Pushed by rempt into branch 'master'.

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_line.cc

http://commits.kde.org/krita/ef6bae61b1ad6330e64e7d3f9e3168874c9c1bf8
Comment 11 Halla Rempt 2016-01-12 07:57:00 UTC
Git commit fed0421cc7e052c795b5451bf994a66ae41d677c by Boudewijn Rempt.
Committed on 12/01/2016 at 07:56.
Pushed by rempt into branch 'calligra/2.9'.

M  +1    -0    krita/plugins/tools/defaulttools/kis_tool_line.cc

http://commits.kde.org/calligra/fed0421cc7e052c795b5451bf994a66ae41d677c