Bug 352670 - 15.09 - SIGABRT when trying to create renderprofile in favourites
Summary: 15.09 - SIGABRT when trying to create renderprofile in favourites
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 17:02 UTC by Paul Konecny
Modified: 2015-12-14 21:47 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In: 15.12.0
Sentry Crash Report:


Attachments
Screencast showing the issue (1.81 MB, video/webm)
2015-09-13 17:02 UTC, Paul Konecny
Details
Backtrace with movit (20.17 KB, text/x-log)
2015-09-13 17:02 UTC, Paul Konecny
Details
Backtrace without movit (18.81 KB, text/x-log)
2015-09-13 17:02 UTC, Paul Konecny
Details
Backtrace with glibc rebuilt (20.88 KB, text/x-log)
2015-09-13 17:50 UTC, Paul Konecny
Details
Screencast showing render crash (1.27 MB, video/webm)
2015-09-14 22:38 UTC, Paul Konecny
Details
Backtrace for render crash (21.29 KB, text/x-log)
2015-09-14 22:39 UTC, Paul Konecny
Details
Screencast showing blank video (2.10 MB, video/webm)
2015-09-15 01:12 UTC, Paul Konecny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Konecny 2015-09-13 17:02:08 UTC
Created attachment 94550 [details]
Screencast showing the issue

Hi J-B, 
I was working on the VP9 render profile again when I tried to create it directly under favourites. 
When I hit save kdenlive crashed. 
After a restart I clicked on render and tried to select favourites again. Now everytime I click on favourites, I get a SIGABRT. 

At first I thought it was a movit problem, but after uninstalling movit I still get SIGABRTs.
Cheers! 
Screencast and backtrace attached.
Version: Master branch 440d300
Comment 1 Paul Konecny 2015-09-13 17:02:38 UTC
Created attachment 94551 [details]
Backtrace with movit
Comment 2 Paul Konecny 2015-09-13 17:02:56 UTC
Created attachment 94552 [details]
Backtrace without movit
Comment 3 Paul Konecny 2015-09-13 17:50:50 UTC
Created attachment 94553 [details]
Backtrace with glibc rebuilt

I just rebuilt glibc with debugging symbols and the magic seems to happen here

Program received signal SIGABRT, Aborted.
0x00007ffff05ba5f8 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:55
55	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.

Also happens in the current 15.08 branch.
Comment 4 Jean-Baptiste Mardelle 2015-09-14 20:41:44 UTC
Git commit acefdbe65a2a3853ee4b9f85327e5750bdca2b85 by Jean-Baptiste Mardelle.
Committed on 14/09/2015 at 20:41.
Pushed by mardelle into branch 'master'.

Fix crash on render profile with empty file extension

M  +9    -6    src/dialogs/renderwidget.cpp

http://commits.kde.org/kdenlive/acefdbe65a2a3853ee4b9f85327e5750bdca2b85
Comment 5 Jean-Baptiste Mardelle 2015-09-14 20:44:25 UTC
Hi Paul,

Thanks for the report. I just fixed the cause for the crash - apparently you created a profile with an empty file extension. Not sure how you created it, will make further tests.

However with my last patch Kdenlive should not crash, let me know
Comment 6 Jean-Baptiste Mardelle 2015-09-14 20:56:25 UTC
Git commit b23a95cf4c0458a5b65ef7bf417f942d25eca71e by Jean-Baptiste Mardelle.
Committed on 14/09/2015 at 20:55.
Pushed by mardelle into branch 'Applications/15.08'.

Fix crash on render profile with empty file extension

M  +9    -6    src/dialogs/renderwidget.cpp

http://commits.kde.org/kdenlive/b23a95cf4c0458a5b65ef7bf417f942d25eca71e
Comment 7 Paul Konecny 2015-09-14 22:38:17 UTC
Created attachment 94566 [details]
Screencast showing render crash

Hi J-B, 
I can tell you how I "created" it. I was trying to figure out a good VP9-CRF profile and I started to go to favourites, and then clicked "create new profile" I then added some parameters and clicked save. On clicking save kdenlive crashed. Unfortunately I don't have a backtrace of that. So I presume this is the reason for this profile having no extension.

Going to favs no longer crashes kdenlive. It just says invalid profile now.
But trying to render something with a profile having the same parameters does. 
Maybe I messed up some settings? 
f=webm acodec=libopus ar=48000 vb=0 ab=%audiobitrate+'k' vcodec=libvpx-vp9 ' crf=%quality speed=1 vprofile=1 tile-columns=6 frame-parallel=1
See attached screencast and backtrace.
This is my custom profiles.xml

<profiles version="1">
 <profile audiobitrates="" defaultaudiobitrate="0" args="f=webm acodec=libopus ar=48000 ab=%audiobitrate+'k' vcodec=libvpx-vp9 ' vb=0 crf=%quality speed=1 vprofile=1 tile-columns=6 frame-parallel=1" extension="" defaultquality="0" qualities="20,33,63" name="VP9-CRF" destinationid="favorites" category="Benutzerdefiniert"/>
 <profile audiobitrates="128,160,192" defaultaudiobitrate="128" args="f=webm acodec=libopus ar=48000 ab=%audiobitrate+'k' vcodec=libvpx-vp9 vb=%bitrate+'M' g=120 bf=2 rc_lookahead=16 quality=good speed=1 vprofile=0 qmax=51 qmin=11 slices=4 arnr_max_frames=7 arnr_strength=5 arnr_type=3" extension="webm" defaultbitrate="2" name="WebM VP9" destinationid="" category="WebM VP9" bitrates="2,4,8"/>
 <profile args="f=webm acodec=libopus ar=48000 ab=%audiobitrate+'k' vcodec=libvpx-vp9 ' crf=%quality speed=1 vprofile=1 tile-columns=6 frame-parallel=1" defaultaudiobitrate="128" audiobitrates="128,160,192" extension="webm" defaultquality="20" qualities="20,33,63" name="VP9 CRF" destinationid="" category="WebM VP9"/>
</profiles>

Thanks!
Comment 8 Paul Konecny 2015-09-14 22:39:51 UTC
Created attachment 94567 [details]
Backtrace for render crash
Comment 9 Jean-Baptiste Mardelle 2015-09-15 00:33:15 UTC
Git commit 9a991f719892dd6911aaf5a550e82fd2010c5fe9 by Jean-Baptiste Mardelle.
Committed on 15/09/2015 at 00:32.
Pushed by mardelle into branch 'master'.

Fix possible crash on render

M  +3    -3    src/timeline/timeline.cpp

http://commits.kde.org/kdenlive/9a991f719892dd6911aaf5a550e82fd2010c5fe9
Comment 10 Paul Konecny 2015-09-15 01:12:19 UTC
Created attachment 94568 [details]
Screencast showing blank video

Hi J-B,
good news is, that your latest commit gets rid of the crash but every render profile I tried gives me an empty file now.
Comment 11 Paul Konecny 2015-09-15 01:57:08 UTC
"I am not a smart man." - Forrest Gump
Well Paul, if you would add something to the timeline there would be pretty little pictures in the output as well... 
My bad. Relsoved, fixed. 
Thanks!
Comment 12 Jean-Baptiste Mardelle 2015-09-15 18:50:45 UTC
Git commit 1e21abf0687bf57db5aba270eedeecbb478efe37 by Jean-Baptiste Mardelle.
Committed on 15/09/2015 at 18:49.
Pushed by mardelle into branch 'Applications/15.08'.

Fix possible crash on render

M  +3    -3    src/timeline/timeline.cpp

http://commits.kde.org/kdenlive/1e21abf0687bf57db5aba270eedeecbb478efe37
Comment 13 Vincent PINON 2015-11-03 21:47:27 UTC
Git commit 60c5cc5c53343990e7a7d42ce35a5bb45a91781e by Vincent Pinon, on behalf of Jean-Baptiste Mardelle.
Committed on 03/11/2015 at 21:14.
Pushed by vpinon into branch 'Applications/15.08'.

Fix crash on render profile with empty file extension

M  +2    -5    src/dialogs/renderwidget.cpp

http://commits.kde.org/kdenlive/60c5cc5c53343990e7a7d42ce35a5bb45a91781e