Bug 352651 - Widgets get pushed off the panel despite flexible spacer [regression]
Summary: Widgets get pushed off the panel despite flexible spacer [regression]
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 5.3.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 349592 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-13 10:10 UTC by kdebuac.rhn
Modified: 2016-09-18 15:31 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the overflowing system tray (11.00 KB, image/png)
2015-09-13 10:11 UTC, kdebuac.rhn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kdebuac.rhn 2015-09-13 10:10:33 UTC
This is a rgression compared to KDE4.

The rightmost widget of the panel is pushed out from the panel in the following configuration:
Horizontal panel, widgets left-to-right: activity list, spacer, system tray.

Whenever a new activity is added, the activity list expands and system tray moves to the right, eventually disappearing completely. This happens regardless of the "flexible" setting on the spacer.
It appears that the spacer isn't reflowed when the list widgets is resized, because removing and re-adding spacer works as expected.

Reproducible: Always

Steps to Reproduce:
1. Reproduce panel configuration.
2. Add activity.

Actual Results:  
Rightmost widget flows off from the panel.

Expected Results:  
Spacer adjusts so that rightmost widget stays on panel.
Comment 1 kdebuac.rhn 2015-09-13 10:11:12 UTC
Created attachment 94532 [details]
Screenshot of the overflowing system tray
Comment 2 mixin 2016-01-28 11:29:02 UTC
Same problem with spacer. 
Related: https://bugs.kde.org/show_bug.cgi?id=349592
Comment 3 Janet 2016-02-21 11:53:53 UTC
I can confirm this on Plasma 5.4.3. If the panel/screen is not wide enough, widgets at the right side of the panel get "lost". Instead fo this behaviour the spacers (I use two) should shrink so that the other content stays visible.
Comment 4 David Edmundson 2016-09-15 00:28:09 UTC
*** Bug 349592 has been marked as a duplicate of this bug. ***
Comment 5 David Edmundson 2016-09-15 00:28:36 UTC
Thanks I can reproduce the bug. Will try and fix.
Comment 6 David Edmundson 2016-09-18 14:52:42 UTC
Git commit 8e1339887a01e078b04fb18ff575c16998447665 by David Edmundson.
Committed on 18/09/2016 at 14:52.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Fix panel spacer

Summary:
An expanding spacer had it's minimum size set to the config.length
Allowing the panel to go from config size to infinite.

The problem is the panel length effectively defaults to the size the
spacer starts at (it gets set when we drag it into the right place)
meaning it starts off huge and can never shrink. This then leads to
applets being pushed off the panel.

We want it to be in expanding mode from 0 to config.length
and non expanding to ideally be a fixed width - though still probably
compress if it would otherwise mean the applets would overflow.

Setting the preferred size does all that implicitly; and also sets the
appropriate hint so you can have a spacer in a flexible width panel
correctly.

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2785

M  +2    -5    applets/panelspacer/contents/ui/main.qml

http://commits.kde.org/plasma-workspace/8e1339887a01e078b04fb18ff575c16998447665
Comment 7 andydecleyre 2016-09-18 15:31:39 UTC
Thank you, I'm excited for this!