Bug 352582 - Build fails if telepathy-qt 0.9.6 is installed
Summary: Build fails if telepathy-qt 0.9.6 is installed
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-11 19:03 UTC by Antonio Rojas
Modified: 2015-09-12 09:14 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kdeconnect-kde/d9be8f970c395ad2f75f1c4fae22649e087478ad
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2015-09-11 19:03:33 UTC 
kdeconnect still tries to build its telepathy support if telepathy-qt 0.9.6 is installed, even though it has been ported to the 0.9.7 API. Probably the build of the telepathy-cm build should be conditioned to TelepathyQt5Service_FOUND (not just to TelepathyQt5_FOUND)

Reproducible: Always
Comment 1 David Edmundson 2015-09-11 19:19:28 UTC 
Git commit 2824260096602b0b567f4551eecd46472a7b9341 by David Edmundson.
Committed on 11/09/2015 at 19:19.
Pushed by davidedmundson into branch 'master'.

Check for both TpQt and TpQt service

M  +1    -1    CMakeLists.txt

http://commits.kde.org/kdeconnect-kde/2824260096602b0b567f4551eecd46472a7b9341
Comment 2 Antonio Rojas 2015-09-11 19:26:20 UTC 
Still fails, same change is needed in line 58
Comment 3 Albert Vaca Cintora 2015-09-11 19:44:42 UTC 
Oops, sorry! Will push a fix now.
Comment 4 David Edmundson 2015-09-11 19:46:31 UTC 
Git commit d9be8f970c395ad2f75f1c4fae22649e087478ad by David Edmundson.
Committed on 11/09/2015 at 19:46.
Pushed by davidedmundson into branch 'master'.

Check for service validity in more places

M  +1    -1    CMakeLists.txt
M  +1    -1    daemon/CMakeLists.txt
M  +1    -1    plugins/telephony/CMakeLists.txt

http://commits.kde.org/kdeconnect-kde/d9be8f970c395ad2f75f1c4fae22649e087478ad
Comment 5 Antonio Rojas 2015-09-12 08:27:50 UTC 
Sorry but still doesn't work: the two if(TelepathyQt5_FOUND AND TelepathyQt5_FOUND) in the last commit should be if(TelepathyQt5_FOUND AND TelepathyQt5Service_FOUND)
Comment 6 David Edmundson 2015-09-12 09:14:59 UTC 
Urgh, so sorry about that. 

Thanks.