Bug 352537 - The Konqueror save file dialog cannot handle quotation marks in file names
Summary: The Konqueror save file dialog cannot handle quotation marks in file names
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: general (other bugs)
Version First Reported In: 4.14.3
Platform: FreeBSD Ports FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Konqueror Bugs
URL: http://yande.re/post/show/303236
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-10 22:29 UTC by Jonathan M Davis
Modified: 2022-11-16 05:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan M Davis 2015-09-10 22:29:32 UTC
If I try and download a file via Konqueror, and it has one or more quotation marks - " - in its name, then it does not work properly. If the file name has a single quotation mark, then clicking on save does nothing, whereas if it has two, then clicking on save results in the filename being only what's between the quotation marks rather than the full filename with the quotation marks embedded in it. If it has three quotation marks in it, the filename ends up being what was between the first two quotation marks. And if four quotation marks are used, then you get an error saying "You can only select one file." I expect that more quotation marks will alternate between the behavior of giving 3 and 4 quotation marks, but I didn't test that. Interestingly enough, if I use one or more single quotes, they work fine. It's just the double quotes that fail.

So, clearly, however the file saving code is implemented for the save dialog in Konqueror, it's interpreting the quotation marks in some manner as if a command were being run in a shell rather than just saving the file. The only characters that should be illegal in a filename on a *nix filesystem are / and \0. Everything else should be legit and should end up in the filename verbatim if it's put in the filename in the save dialog, and clearly that's not happening.

Reproducible: Always

Steps to Reproduce:
This should be testable by downloading any file and putting quotation marks in its name, but if you go to this page:

http://yande.re/post/show/303236

and right click on the "Download larger version" link to select "Save link as..." and then use that  save file dialog, you get a filename to try and save that already has " in it. Similarly, if you go to this page

http://yande.re/post/show/330666

and right click on the "Download larger version" link to "Save link as..." you get a filename to try and save that already has two " in it.

Actual Results:  
If the file name has a single " in it, then the save button does nothing, whereas if it has two " in it, then the filename that ends up on disk is what was between the quotes rather than the full filename that was provided. 3 quotation marks gives you what was between the first two quotes, and 4 quotation marks results in an error dialog popping up.

Expected Results:  
The resultant filename is exactly what was entered in the save file dialog, even if it has special characters in it like a ".
Comment 1 Justin Zobel 2022-10-17 00:41:00 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 2 Bug Janitor Service 2022-11-01 05:05:53 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2022-11-16 05:17:25 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!