Bug 352473 - plugin installs into wrong location
Summary: plugin installs into wrong location
Status: RESOLVED FIXED
Alias: None
Product: kwebkitpart
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: webkit-devel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-09 10:29 UTC by Jonathan Marten
Modified: 2015-12-16 19:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Marten 2015-09-09 10:29:24 UTC
The frameworks branch of the webkit part builds, but the installation location of the plugin seems to be incorrect.  In src/CMakeLists.txt it installs into ${PLUGIN_INSTALL_DIR} which resolves to PREFIX/lib64/plugins.  However, Konqueror seems to be looking for the part elsewhere:

konqueror(18116)/default KPluginLoader::KPluginLoader: Error loading plugin "kf5/parts/kwebkitpart" "The shared library was not found."

All other parts (e.g. from khtml, ktexteditor etc) seem to install using ${KDE_INSTALL_PLUGINDIR}/kf5/parts which resolves to PREFIX/lib64/plugins/kf5/parts.  Moving the libkwebkitpart.so into this subdirectory allows Konqueror to correctly locate the part.


Reproducible: Always




According to ECM/kde-modules/KDEInstallDirs.cmake the preferred installation variables for this (and the other webkitpart components) should be:

kwebkitpart                 ${KDE_INSTALL_PLUGINDIR}/kf5/parts
kwebkitpart.desktop   ${KDE_INSTALL_KSERVICES5DIR}
kwebkitpart.rc             ${KDE_INSTALL_KXMLGUI5DIR}/kwebkitpart
error.html                    ${KDE_INSTALL_DATADIR}/kwebkitpart
Comment 1 Jonathan Marten 2015-09-09 10:32:28 UTC
Sorry, wrong product
Comment 2 Jonathan Marten 2015-12-16 19:06:48 UTC
Git commit 1bc070919e59c4489f47d0abb465a6bdb73790b6 by Jonathan Marten.
Committed on 16/12/2015 at 19:05.
Pushed by marten into branch 'frameworks'.

Install plugin into the correct KParts location

M  +4    -4    src/CMakeLists.txt

http://commits.kde.org/kwebkitpart/1bc070919e59c4489f47d0abb465a6bdb73790b6