Bug 352345 - Quick activity switch makes it use wrong wallpaper
Summary: Quick activity switch makes it use wrong wallpaper
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.4.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL: https://youtu.be/nyajG72EQME
Keywords:
: 364272 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-06 10:50 UTC by soee
Modified: 2016-09-19 16:29 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description soee 2015-09-06 10:50:05 UTC
If we use ome shortcuts for quick switch activities, than activities starts to use wrong walllpaper (used by other activities).

Reproducible: Always

Steps to Reproduce:
1. Create 2-3 or more activies
2. Start quick switching it (using shortcuts or switcher)
3. Selected activity strts to use wrong wallpaper (from different activity)

Actual Results:  
Selected activity losts own wallpaper and starts using wallpaper from different activities.

Expected Results:  
Selected activity shoudl always use own wallpaper.
Comment 1 Kai Uwe Broulik 2015-09-07 20:50:58 UTC
I've seen this happen too. Sometimes Plasma gets confused and shows the wrong activity contrary to kwin.
Comment 2 Elias Probst 2015-10-16 12:04:32 UTC
Seen this only happen when looping over the activities really fast - seems to be a race condition to me.
Comment 3 Kai Uwe Broulik 2015-12-28 14:39:14 UTC
This is most likely the switch animation getting confused, ie. at the end of the animation the containment is different than at the beginning.
Comment 4 soee 2016-05-10 11:42:11 UTC
Bug still exists in Plasma 5.6.3.
Comment 5 soee 2016-05-10 11:43:25 UTC
I should add that the quick switch also makes desktop widgets in activities to be gone.
Comment 6 Kai Uwe Broulik 2016-06-13 20:35:33 UTC
*** Bug 364272 has been marked as a duplicate of this bug. ***
Comment 7 Marco Martin 2016-09-19 16:29:04 UTC
Git commit 49131300b7e873c8d7455309025479d753039ed5 by Marco Martin.
Committed on 19/09/2016 at 16:28.
Pushed by mart into branch 'Plasma/5.8'.

Make sure to animate proper containments

Summary:
if the activity is changed again while the switch animation
is being performed, the desktop finds itself in an
inconsistent state, as oldContainment and newContainment
values gets changed while the animation is running.
this makes sure the animation is stopped and all the values
are resetted if the containment changes before the anim is done

Test Plan: tried with the animation made really slow, was easy to reproduce 352345, then the problem went away with the patch

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2814

M  +33   -24   desktoppackage/contents/views/Desktop.qml

http://commits.kde.org/plasma-desktop/49131300b7e873c8d7455309025479d753039ed5