Bug 352338 - Digikam doesn't match Nikon lenses 35mm f/1.8G and 50mm f/1.8G
Summary: Digikam doesn't match Nikon lenses 35mm f/1.8G and 50mm f/1.8G
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-LensCorrection (show other bugs)
Version: 4.12.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-06 08:36 UTC by Tokes
Modified: 2016-07-01 09:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.14.0
Sentry Crash Report:


Attachments
Screenshots of autodetected lenses (25.81 KB, image/png)
2015-09-06 08:36 UTC, Tokes
Details
Sample image taken using 35mm 1.8f object (1.93 MB, image/jpeg)
2015-09-06 19:40 UTC, Tokes
Details
Sample image taken using 50mm 1.8f object (1.90 MB, image/jpeg)
2015-09-06 19:43 UTC, Tokes
Details
3rd sample image taken using 18-105mm object (1.70 MB, image/jpeg)
2015-09-07 20:21 UTC, Tokes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tokes 2015-09-06 08:36:43 UTC
Created attachment 94423 [details]
Screenshots of autodetected lenses

Moin,
in Image Editor -> Enhance -> Lens -> Auto-Correction images taken by my Nikon D7000 and fixed focal length lenses 35mm f/1.8 and 50mm f/1.8 are not detected correctly. Instead a wrong lens is selected in the listbox. Since the lenses are available in the listbox, I assume it is just a matter of matching.

Displayed Lens: Nikon AF-S DX Nikkor 35 f/1.8G
suitable Listbox entry: Nikon Nikkor 35mm f/1.8G AF-S DX

Displayed Lens: Nikon AF-S Nikkor 50mm f/1.8G
suitable Listbox entry: Nikkor 50mm f/1.8 AI-S

Please fix this.

Reproduced using Digikam 4.12 in Windows and Digikam 4.0 in Linux Mint.

Best
Comment 1 caulier.gilles 2015-09-06 08:46:01 UTC
Please provide a sample image to reproduce the problem.

Use web hosting service, because bugzilla has file size limitation

Gilles Caulier
Comment 2 Tokes 2015-09-06 19:40:12 UTC
Created attachment 94434 [details]
Sample image taken using 35mm 1.8f object
Comment 3 Tokes 2015-09-06 19:43:33 UTC
Created attachment 94435 [details]
Sample image taken using 50mm 1.8f object
Comment 4 Maik Qualmann 2015-09-07 06:04:31 UTC
Here both images are detected with LibLensFun-0.3.1 with exact matches. Which version of LibLensFun you have installed?

Maik
Comment 5 Maik Qualmann 2015-09-07 06:10:25 UTC
Which version of libExiv2 have installed? Look in components info dialog from digiKam.

Maik
Comment 6 Tokes 2015-09-07 17:48:08 UTC
Hi Gilles and Maik,
thanks a lot for the rapid replies.

My Windows digikam 4.12 ships with an older version of LibLensFun: 0.2.6-0, guess that's the problem.
Haven't checked in Linux Mint 17.2 with digikam 4.0, but I assume it is the same thing.

Below you find the complete list of component versions of Windows digikam 4.12.

Could you please trigger the compilation of a windows version bundled with the updated version of LibLensFun? In the meanwhile I am considering switching from Linux Mint 17.2 back to Kubuntu 15.04, since I was not able get a recent version of digikam running using philip5's ppa.

Thanks a lot for your help!

digiKam version 4.12.0
CPU cores: 4
Demosaic GPL2 pack support: No
Demosaic GPL3 pack support: No
Exiv2 can write to Jp2: Yes
Exiv2 can write to Jpeg: Yes
Exiv2 can write to Pgf: Yes
Exiv2 can write to Png: Yes
Exiv2 can write to Tiff: Yes
Exiv2 supports XMP metadata: Yes
LibCImg: 130
LibEigen: 3.2.0
LibExiv2: 0.25
LibJPEG: 90
LibJasper: 1.900.1
LibKDE: 4.10.2
LibKExiv2: 2.4.0
LibKGeoMap: 3.1.0
LibKdcraw: 2.4.2
LibLCMS: 2040
LibLensFun: 0.2.6-0
LibLqr support: yes
LibPGF: 6.14.12
LibPNG: 1.5.14
LibQt: 4.8.4
LibRaw: 0.16.0
LibTIFF: LIBTIFF, Version 3.9.2 Copyright (c) 1988-1996 Sam Leffler Copyright (c) 1991-1996 Silicon Graphics, Inc.
Marble Widget: 0.15.1 (stable version)
Parallelized demosaicing: No
RawSpeed codec support: No
Baloo support: no
Database backend: QSQLITE
Kdepimlibs support: no
Kipi-Plugins: 4.12.0
LibGphoto2 support: no
LibKface: 3.5.0
LibKipi: 2.2.0
LibOpenCV: 2.4.9
Sqlite2 support: no
Comment 7 Tokes 2015-09-07 20:19:55 UTC
Running digikam 4.13 in kubuntu 15.04 and libLensFun 0.3.1-0 the lenses of both images are correctly matched, thanks again for the hint!

Unfortunately, now another lens (that was previously detected correctly) is now no longer detected:
Lens: Nikon AF-S DX VR Zoom-Nikkor 18-105 f/3.5-5.6G ED VR

Sample image 18-105-2.jpg is attached below.
Comment 8 Tokes 2015-09-07 20:21:21 UTC
Created attachment 94460 [details]
3rd sample image taken using 18-105mm object
Comment 9 Maik Qualmann 2015-09-16 06:13:12 UTC
Git commit 4fe55931acada0e05ae0ede95f5ac79db80e9a4a by Maik Qualmann.
Committed on 16/09/2015 at 06:04.
Pushed by mqualmann into branch 'master'.

optimization the lens detection in the auto-correction filter
FIXED-IN: 4.14.0

M  +2    -1    NEWS
M  +3    -0    libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/4fe55931acada0e05ae0ede95f5ac79db80e9a4a
Comment 10 caulier.gilles 2015-09-16 06:31:25 UTC
Git commit e4336f78f161d7e6ed304b573e83d5b77ac84a21 by Gilles Caulier.
Committed on 16/09/2015 at 06:30.
Pushed by cgilles into branch 'frameworks'.

backport commit #4fe55931acada0e05ae0ede95f5ac79db80e9a4a from git/master to frameworks branch

M  +3    -0    libs/dimg/filters/lens/lensfuniface.cpp

http://commits.kde.org/digikam/e4336f78f161d7e6ed304b573e83d5b77ac84a21
Comment 11 Tokes 2015-09-20 15:34:53 UTC
Thank you for the rapid fix! I will test as soon as the new version is shipped under linux