Bug 352253 - Advanced Color Selector "Triangle Selector" View Shows Multiple Triangles When Scaling the Docker
Summary: Advanced Color Selector "Triangle Selector" View Shows Multiple Triangles Whe...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (other bugs)
Version First Reported In: 2.9.7
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL: http://i.imgur.com/BiVp4nL.jpg
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-04 05:06 UTC by Dennis Brown
Modified: 2015-09-05 12:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Video. (210.74 KB, video/mp4)
2015-09-04 06:53 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Brown 2015-09-04 05:06:07 UTC
When scaling the ACS down from it's maximum size, using the default triangle selector, the largest triangle picker, and any size between it and the currently scaled size is shown behind the picker, and outside of the circle. 

Currently this only happens to the triangle selector with every color mode, but none of the others. 

Reproducible: Always

Steps to Reproduce:
1. Switch Advanced Color Selector "Selector" type to the wheel with triangle. 
2.  Using the Windows size slider, decrease the size of the ACS
3. Observe as the triangle sizes continue to exist in the background, and can still be selected from the overflow

Actual Results:  
The triangle selector continues to show it's largest size, as well as the sizes in between the largest to the current size,  and colors can still be picked outside of the circle where these old pickers reside. 

Expected Results:  
Expected results would be for the current size triangle to be the only one shown, as it was in 2.9.6. 

Workaround: Do not scale the ACS down in size at all, or use a different selector. Even using the triangle, actual functionality is not lost.
Comment 1 Dennis Brown 2015-09-04 05:08:46 UTC
Full version information: 2.9.7 (git c89ac6a)
OS: Win X
Comment 2 mvowada 2015-09-04 06:53:51 UTC
Created attachment 94394 [details]
Video.

I can confirm with Krita: 2.9.6 (git edd766e).
Comment 3 Halla Rempt 2015-09-05 12:05:28 UTC
Git commit 5bd1de6cbf791964cb980f294c0b57ad5a7c3e00 by Boudewijn Rempt.
Committed on 05/09/2015 at 12:04.
Pushed by rempt into branch 'calligra/2.9'.

M  +4    -0    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp
M  +2    -2    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.h

http://commits.kde.org/calligra/5bd1de6cbf791964cb980f294c0b57ad5a7c3e00
Comment 4 Halla Rempt 2015-09-05 12:08:23 UTC
Git commit ef47a739ac4de6d005af55c331ec976fc082e791 by Boudewijn Rempt.
Committed on 05/09/2015 at 12:08.
Pushed by rempt into branch 'master'.

M  +4    -0    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp
M  +2    -2    krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.h

http://commits.kde.org/calligra/ef47a739ac4de6d005af55c331ec976fc082e791