Bug 352156 - master build uses qtpositioning always but finds it optionally
Summary: master build uses qtpositioning always but finds it optionally
Status: RESOLVED DUPLICATE of bug 352242
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL: https://launchpadlibrarian.net/216058...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-02 10:57 UTC by Harald Sitter
Modified: 2015-09-05 11:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2015-09-02 10:57:52 UTC 
In git master there is an optional find_package on qt5positioning

> CMakeLists.txt:   find_package(Qt5Positioning)

and an unprotected include in

> ./src/lib/marble/declarative/Placemark.cpp:#include <QGeoAddress>

ultimately resulting in a build failure if qt5positioning is not found

> ../../../../../src/lib/marble/declarative/Placemark.cpp:14:23: fatal error: QGeoAddress: No such file or directory




Reproducible: Always


Actual Results:  
should either mark qt5positioning REQUIRE in cmake or make the QGeoAddress use conditional to whether positioning was found
Comment 1 Dennis Nienhüser 2015-09-03 19:28:44 UTC 
Rex Dieter was working on a patch to improve the optional switch between Qt4 and Qt5 in Marble's cmake files. Once that is in we can mark all Qt modules REQUIRED.
Comment 2 Dennis Nienhüser 2015-09-05 11:52:31 UTC 

*** This bug has been marked as a duplicate of bug 352242 ***