Bug 352118 - Baloo 5.13.0: tags in tags:/ kioslave don't have an icon
Summary: Baloo 5.13.0: tags in tags:/ kioslave don't have an icon
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: icons (show other bugs)
Version: 5.4.2
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: pinheiro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-01 20:21 UTC by Christian (Fuchs)
Modified: 2016-07-04 17:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2015-09-01 20:21:22 UTC
tags listed via the tags:/ kioslave (e.g. in dolphin) have no icon.
Happens with both breeze and oxygen as the icon set

Reproducible: Always

Steps to Reproduce:
1. Open dolphin
2. Go to tags:/


Actual Results:  
Tags are listed but have no icon (just a white, blank space and the name)

Expected Results:  
Tags have the usual tags icon as they did before
Comment 1 Christian (Fuchs) 2015-09-26 23:21:35 UTC
The issue seems to be in baloo-5.14.0/src/kioslaves/tags/kio_tags.cpp

Line 66: 
    uds.insert(KIO::UDSEntry::UDS_ICON_NAME, QLatin1String("tag"));

There is no icon called "tag", thus the "unknown" icon is taken which, due to a different bug, isn't shown in dolphin. 

Solutions: 

1) Change that line to an icon that actually does exist
2) Ask the VDG / whoever to create an icon for breeze / oxygen that is called tag
Comment 2 Christian (Fuchs) 2015-10-10 18:03:45 UTC
Apparently in breeze there (now) is an icon called tag, so if someone could just create a link to the tag icon in oxygen called "tag", that would fix this. 

Thus re-assigning (or trying to)
Comment 3 pinheiro 2016-07-04 17:15:20 UTC
so tag.png  in what sub-type of icon (action, file...?) and its it an overlay ?
Comment 4 Christian (Fuchs) 2016-07-04 17:28:02 UTC
Sorry, this seems to be fixed in recent versions. 
As I don't have a vanilla KDE at hand: 

if the entries in   tags:/    have an icon, this is fixed and can be closed. Works here. 

Thanks :)