Bug 352058 - Restart/Reboot naming isn't consistent
Summary: Restart/Reboot naming isn't consistent
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.3.2
Platform: Chakra Linux
: NOR minor
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 13:12 UTC by Nick
Modified: 2016-05-04 15:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick 2015-08-31 13:12:29 UTC
The option to restart the computer in the menu is:

    Power/Session -> Restart

The graphical notification bar indicating the restart in 30 seconds reads ... Reboot

Is there a reason the word changed?  I know this is minor... really minor.. but it feels inconsistent.

Reproducible: Always
Comment 1 Eike Hein 2015-08-31 13:18:15 UTC
Good catch. David, which do you prefer?
Comment 2 kdebugs 2016-03-24 07:23:14 UTC
While you're at it, please fix "Shutdown" and "Shut down".

In English, "shutdown" is considered a noun, while "shut down" is the verb phrase.  Thus, if you "shut it down" twice, that's two "shutdowns".

In KDE4, the menu has it right: "Shut down", but the Alt-F2 launcher has it wrong: "Shutdown the computer".  The pop-up uses "Turning off the computer in 29 seconds." which is ok with me.

In KDE5, the menu has it wrong: "Shutdown", as does the Alt-F2 launcher: "Shutdown the computer".  The pop-up uses "Shutting down" which is fine.
Comment 3 Eike Hein 2016-03-24 07:29:52 UTC
^ Good feedback, thanks!
Comment 4 Sudhir Khanger 2016-04-22 10:55:47 UTC
Hi Eike,

Is naming scheme Suspend to RAM for Suspend and Suspend to Disk for Hibernate is intentional?

AppDash, Kicker, and Kickoff use Suspend for Suspend to RAM and Hibernate to Suspend to Disk. Why are we not using same names for KRunner?

Thanks.
Comment 5 Eike Hein 2016-04-22 14:51:20 UTC
I'd suggest asking the VDG for input and then submitting patches.
Comment 6 Sudhir Khanger 2016-04-22 15:30:51 UTC
Leaving the link to the thread I created a few days ago.

https://forum.kde.org/viewtopic.php?f=285&t=132369
Comment 7 David Edmundson 2016-04-29 23:09:20 UTC
>Good catch. David, which do you prefer?

(I may not be the fastest to reply, but I get there in the end)

Reboot.

Restart has the potential to be vague (restart what?). 
Whereas reboot heavily implies hardware.

I've patched the shutdown strings already. I'll do this reboot one too.

The suspend thing is more of a different issue that I'll leave to the forum. I think we're at least consistent there.
Comment 8 David Edmundson 2016-05-04 11:39:07 UTC
Git commit 7f1e656923218fc81a5a8a326128f38b9aaab1c4 by David Edmundson.
Committed on 04/05/2016 at 11:38.
Pushed by davidedmundson into branch 'master'.

Fix usage of string "shut down"

Some say shutdown, some say shut down.
REVIEW: 127792

M  +1    -1    daemon/actions/bundled/handlebuttoneventsconfig.cpp
M  +1    -1    daemon/actions/bundled/suspendsessionconfig.cpp
M  +1    -1    kcmodule/activities/activitywidget.cpp
M  +1    -1    kcmodule/global/GeneralPage.cpp

http://commits.kde.org/powerdevil/7f1e656923218fc81a5a8a326128f38b9aaab1c4
Comment 9 David Edmundson 2016-05-04 13:59:27 UTC
Git commit dd67a42cd5170c73ad50c4a0e9ccf6dfd0aa30e9 by David Edmundson.
Committed on 04/05/2016 at 11:51.
Pushed by davidedmundson into branch 'master'.

Fix usage of string "shutdown" and "restart"

Some say shutdown, some say shut down.

We want reboot consistently instead of restart (when talking about the
computer)
REVIEW: 127790

M  +2    -2    applets/kicker/plugin/systementry.cpp

http://commits.kde.org/plasma-desktop/dd67a42cd5170c73ad50c4a0e9ccf6dfd0aa30e9
Comment 10 David Edmundson 2016-05-04 15:48:15 UTC
Git commit 16bc876686625984842e017e9ee0c516e7f59d00 by David Edmundson.
Committed on 04/05/2016 at 15:48.
Pushed by davidedmundson into branch 'master'.

Fix usage of string "shut down"

Some say shutdown, some say shut down.
REVIEW: 127791

M  +1    -1    lookandfeel/contents/components/LogoutOptions.qml

http://commits.kde.org/plasma-workspace/16bc876686625984842e017e9ee0c516e7f59d00