Bug 352057 - Kdenlive segmentation fault on starting DVD Wizard (OpenGL context issue)
Summary: Kdenlive segmentation fault on starting DVD Wizard (OpenGL context issue)
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Display & Export (show other bugs)
Version: unspecified
Platform: ROSA RPMs Linux
: NOR crash
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-31 13:12 UTC by Pulfer
Modified: 2016-07-13 14:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
DVD Wizard window when timer is set to 0 (33.70 KB, image/png)
2016-07-13 03:00 UTC, Pulfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pulfer 2015-08-31 13:12:16 UTC
Kdenlive from current master segfaults trying to run GLWidget::initializeGL().

#0  0xb5d4742a in QOpenGLContext::makeCurrent(QSurface*) () from /usr/lib/libQt5Gui.so.5
#1  0x0835e47d in GLWidget::initializeGL (this=0x9482298) at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/src/monitor/glwidget.cpp:125
#2  0x0836a516 in Monitor::slotOpenDvdFile (this=0x9481d00, file=...)
    at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/src/monitor/monitor.cpp:1083
#3  0x08339a05 in DvdWizardChapters::slotUpdateChaptersList (this=0x995ed88)
    at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/src/dvdwizard/dvdwizardchapters.cpp:69
#4  0x08339deb in DvdWizardChapters::setVobFiles (this=0x995ed88, format=PAL, movies=..., durations=..., chapters=...)
    at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/src/dvdwizard/dvdwizardchapters.cpp:183
#5  0x0833deac in DvdWizard::slotPageChanged (this=0x9982190, page=0)
    at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/src/dvdwizard/dvdwizard.cpp:164
#6  0x08472fb2 in DvdWizard::qt_static_metacall (_o=0x0, _id=155722392, _a=0xbfffd1c8, _c=<optimized out>)
    at /home/vuohi/rpm/BUILD/kdenlive-15.08.0/build/src/moc_dvdwizard.cpp:114
#7  0xb5a3c158 in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/libQt5Core.so.5
#8  0xb5a3c82d in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /usr/lib/libQt5Core.so.5
#9  0xb6ebe755 in QWizard::currentIdChanged(int) () from /usr/lib/libQt5Widgets.so.5
...


Reproducible: Always

Steps to Reproduce:
1. Run DVD Wizard.
2. Add vob file 
3. Click Next



Happens with both Kdenlive 15.08.0 and current master (several commits ahead from 15.08.0). Qt 5.4.2.
Comment 1 Jean-Baptiste Mardelle 2015-09-11 19:08:46 UTC
I cannot reproduce. Some changes were recently made to the OpenGL code, can you please test again with a recent git ? Is this happening only sometimes or everytime you repeat these steps?
Comment 2 Pulfer 2015-09-12 02:30:40 UTC
(In reply to Jean-Baptiste Mardelle from comment #1)
> I cannot reproduce. Some changes were recently made to the OpenGL code, can
> you please test again with a recent git ? Is this happening only sometimes
> or everytime you repeat these steps?

Yes, it still happens every time with the current master.

openglContext() seems to be NULL in GLWidget::initializeGL() when creating monitor widget for DVD Wizard.

Does it work for you with Qt 5.4.2 (just to be sure it's not a Qt bug)?
Comment 3 Pulfer 2015-09-18 07:20:43 UTC
Meanwhile I tested 15.08.1.

1. Still segfaults with KDE 4, Qt 5.4.2 or Qt 5.5.0 and KF 5.14 (confirmed by other people).
2. Doesn't segfault with Plasma 5.

Maybe you cannot reproduce the issue because you tried to do it only with Plasma 5?
Comment 4 Pulfer 2015-12-29 16:38:44 UTC
I just tried 15.12.0. It doesn't segfault in KDE 4 but DVD Wizard dialog window hangs when pressing "Next" button.
Comment 5 Pulfer 2016-04-28 13:39:33 UTC
(In reply to Pulfer from comment #4)
> I just tried 15.12.0. It doesn't segfault in KDE 4 but DVD Wizard dialog
> window hangs when pressing "Next" button.

Still the same with kdenlive 16.04.0 in KDE4.
Comment 6 Pulfer 2016-07-12 20:19:04 UTC
Just checked kdenlive 16.04.3 (Qt 5.6.1, KF 5.24.0), still hangs in KDE4 when trying to create DVD with wizard.
Comment 7 Jean-Baptiste Mardelle 2016-07-12 22:53:16 UTC
Git commit 9a006b87cca38186c7c58ace9a23c338d6c67487 by Jean-Baptiste Mardelle.
Committed on 12/07/2016 at 22:53.
Pushed by mardelle into branch 'master'.

Fix freeze in DVD Wizard

M  +1    -4    src/dvdwizard/dvdwizardchapters.cpp
M  +5    -0    src/dvdwizard/dvdwizardvob.cpp
M  +1    -0    src/dvdwizard/dvdwizardvob.h

http://commits.kde.org/kdenlive/9a006b87cca38186c7c58ace9a23c338d6c67487
Comment 8 Pulfer 2016-07-13 03:00:44 UTC
Created attachment 100053 [details]
DVD Wizard window when timer is set to 0

(In reply to Jean-Baptiste Mardelle from comment #7)
> Git commit 9a006b87cca38186c7c58ace9a23c338d6c67487 by Jean-Baptiste

Thanx, it's almost fixed now. :-) Can you please set timer to 1000 to completely fix it?

-    QTimer::singleShot(0, this, SLOT(slotUpdateChaptersList()));
+    QTimer::singleShot(1000, this, SLOT(slotUpdateChaptersList()));
Comment 9 Jean-Baptiste Mardelle 2016-07-13 09:37:29 UTC
Git commit 8e957fddf1745ba93317e49958b7b9d5dc74126d by Jean-Baptiste Mardelle.
Committed on 13/07/2016 at 09:37.
Pushed by mardelle into branch 'master'.

Another attempt to fix DVD Wizard freeze

M  +4    -4    src/dvdwizard/dvdwizard.cpp
M  +1    -2    src/dvdwizard/dvdwizardchapters.cpp

http://commits.kde.org/kdenlive/8e957fddf1745ba93317e49958b7b9d5dc74126d
Comment 10 Pulfer 2016-07-13 10:14:12 UTC
(In reply to Jean-Baptiste Mardelle from comment #9)
> Git commit 8e957fddf1745ba93317e49958b7b9d5dc74126d

With this patch it doesn't work again.
Comment 11 Jean-Baptiste Mardelle 2016-07-13 14:17:07 UTC
Git commit 7f0b39c1aa6af2b43bfd3eac55049816c17a901d by Jean-Baptiste Mardelle.
Committed on 13/07/2016 at 14:16.
Pushed by mardelle into branch 'master'.

DVD Wizard cleanup, make chapters optional, should solve freeze

M  +2    -2    src/dvdwizard/dvdwizard.cpp
M  +17   -6    src/dvdwizard/dvdwizardchapters.cpp
M  +1    -0    src/dvdwizard/dvdwizardchapters.h
M  +1    -1    src/monitor/monitormanager.cpp
M  +114  -71   src/ui/dvdwizardchapters_ui.ui

http://commits.kde.org/kdenlive/7f0b39c1aa6af2b43bfd3eac55049816c17a901d
Comment 12 Pulfer 2016-07-13 14:43:18 UTC
(In reply to Jean-Baptiste Mardelle from comment #11)
> Git commit 7f0b39c1aa6af2b43bfd3eac55049816c17a901d

Seems to fix now, thanx :-)