Bug 351973 - Missing Comment in desktop file
Summary: Missing Comment in desktop file
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-29 15:30 UTC by Alex
Modified: 2015-08-30 14:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2015-08-29 15:30:32 UTC
Please add Comment in desktop file.

Reproducible: Always
Comment 1 Albert Astals Cid 2015-08-30 12:14:16 UTC
It is not required by the spec, don't see why we should provide one.

Please state your need for it.
Comment 2 Alex 2015-08-30 12:19:49 UTC
With your logic: GenericName is not required by the spec too. Why did you add GenericName? Maybe delete? Not?
"Comment" is tooltip for Modern Style Menu KDE. "Comment" is tooltip if you put desktop file on the Desktop. "Comment" is tooltip for other DEs. etc.
Everybody wants to have high quality Menu and not only for KDE. It should be done for all KDE apps.
Comment 3 Albert Astals Cid 2015-08-30 12:29:05 UTC
Because having a GenericName makes sense, why would i delete it?

> "Comment" is tooltip for Modern Style Menu KDE. "Comment" is tooltip if you 
> put desktop file on the Desktop. "Comment" is tooltip for other DEs. etc.

They are doing it wrong, the spec is quite clear you should not be redundant, "Comment:	Tooltip for the entry, for example 'View sites on the Internet'. The value should not be redundant with the values of Name and GenericName. " so if there's no Comment those DEs should be falling back to GenericName and then to Name. Please propose patches to those projects.
Comment 4 Alex 2015-08-30 12:45:54 UTC
> Because having a GenericName makes sense
Yes, for KDE only.
Having a Comment makes sense too.

> They are doing it wrong, 
Not. You do it wrong. Missing DE, what uses GenericName, except KDE. But Comment is in use by KDE too. If somebody want to add "Keywords" or other optional key, why not?

> the spec is quite clear you should not be redundant
You understand spec wrong. Spec is about: Name <> GenericName <> Comment. All fields are different.
Comment 5 Albert Astals Cid 2015-08-30 12:50:13 UTC
Please provide a comment.
Comment 6 Alex 2015-08-30 12:54:40 UTC
Thanks for understanding.

Proposal:
Universal document viewer
Comment 7 Albert Astals Cid 2015-08-30 12:57:14 UTC
Unfortunately that's redudant with the generic name and thus agains the spec.
Comment 8 Alex 2015-08-30 13:09:43 UTC
grep -ir "Universal document viewer"
empty.

Name=Okular
GenericName=Document Viewer
Comment=Universal document viewer

Do you like "Multi-document viewer software" for Comment?
Comment 9 Albert Astals Cid 2015-08-30 14:42:39 UTC
yeah redundant doesn't mean exactly the same words, means "saying kind of the same", but whatever
Comment 10 Albert Astals Cid 2015-08-30 14:43:44 UTC
Git commit ab8944dcceac7c37434f6499dffc9d6850d56c4c by Albert Astals Cid.
Committed on 30/08/2015 at 14:43.
Pushed by aacid into branch 'master'.

Add Comment

M  +1    -0    generators/chm/okularApplication_chm.desktop
M  +1    -0    generators/comicbook/okularApplication_comicbook.desktop
M  +1    -0    generators/djvu/okularApplication_djvu.desktop
M  +1    -0    generators/dvi/okularApplication_dvi.desktop
M  +1    -0    generators/epub/okularApplication_epub.desktop
M  +1    -0    generators/fax/okularApplication_fax.desktop
M  +1    -0    generators/fictionbook/okularApplication_fb.desktop
M  +1    -0    generators/kimgio/okularApplication_kimgio.desktop
M  +1    -0    generators/mobipocket/okularApplication_mobi.desktop
M  +1    -0    generators/ooo/okularApplication_ooo.desktop
M  +1    -0    generators/plucker/okularApplication_plucker.desktop
M  +1    -0    generators/poppler/okularApplication_pdf.desktop
M  +1    -0    generators/spectre/okularApplication_ghostview.desktop
M  +1    -0    generators/tiff/okularApplication_tiff.desktop
M  +1    -0    generators/txt/okularApplication_txt.desktop
M  +1    -0    generators/xps/okularApplication_xps.desktop
M  +1    -0    shell/okular.desktop

http://commits.kde.org/okular/ab8944dcceac7c37434f6499dffc9d6850d56c4c