Bug 351869 - Add/remove buttons remain visible after using Desktop grid effect
Summary: Add/remove buttons remain visible after using Desktop grid effect
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-window-management (show other bugs)
Version: git master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/124...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-27 17:11 UTC by Jure Repinc
Modified: 2015-09-14 20:07 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kwin/584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d
Version Fixed In: 5.4.2
thomas.luebking: ReviewRequest+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jure Repinc 2015-08-27 17:11:07 UTC 
i have Desktop Grid effect set to be activated with mouse in the lower right corner of the screen. When I activate it and click on the window in the grid the desktop gets shown fine. But when i do this the second time and now click on a different window on the desktop the after I get returned to the window and desktop the Add/Remove  Desktop buttons remain visible in the lower right corner. They now also prevent activating Desktop Grid by moving the mouse to that corner.

Reproducible: Always

Steps to Reproduce:
1. Make sure you have two windows open on one of the virtual desktops.
2. Activate Desktop Grid effect
3. Click on the first window to exit the effect and return to window and desktop
4. Activate Desktop Grid effect again
5. Click on the other window that is open on the desktop

Actual Results:  
Desktop Grid effect is deactivated and you ae returned to window and desktop you clicked on. but now the Add/Remove Desktop buttons are always visible in lower-right corner.

Expected Results:  
Add/Remove Desktop buttons should be hidden
Comment 1 Thomas Lübking 2015-08-27 17:17:22 UTC 
Can you try to apply this patch:
https://git.reviewboard.kde.org/r/124888/
Comment 2 Thomas Lübking 2015-08-27 21:23:16 UTC 
Git commit 9139cca72c5612482c8c27e70196d583630772af by Thomas Lübking.
Committed on 27/08/2015 at 20:21.
Pushed by luebking into branch 'Plasma/5.4'.

never trigger edges during the cooldown

regardless of whether the pushback is forced down or the user
has deactivated it or whatever. The edge is waiting from previous
activation and we need to prevent immediate reactivation since that
may cause duplicate action and unwanted state toggles
Related: bug 351627
FIXED-IN: 5.4.1
REVIEW: 124888

M  +4    -0    screenedge.cpp

http://commits.kde.org/kwin/9139cca72c5612482c8c27e70196d583630772af
Comment 3 Thomas Lübking 2015-08-28 21:01:47 UTC 
Nope, there's more to it.
Fixing patch: https://git.reviewboard.kde.org/r/124970/

Sorry for the trouble.
Comment 4 andreas_k 2015-09-12 09:28:58 UTC 
Hi,

The VDG is focus on an consistent design for plasma and we are also looking into the Desktop Grid Effect. 

Here you get the information how it should work in general: http://user-prompt.com/look-and-feel-of-plasma-sidebars/

So the idea is for the desktop grid effect that you have an Title on top that the user know it's the destkop grid than above the desktop previews and on bottom an panel for global actions e.g. remove last desktop, add new desktop, ... future things

The thing is that it is really nice that the user can add desktops without using SystemSettings. And if you get the same behaviour in ALL Plasma views it would be better to understand. e.g. in the Grid View noone knows what the plus and delete button are used for because there is no tooltop or label.

Would it be a way you would like to go or do I don't understand your problem.
Comment 5 Thomas Lübking 2015-09-12 13:57:24 UTC 
Andreas, this is a technical bug.
Because creating QtQuick views is *incredibly* slow, we now keep and "hide" them by moving them out of sight. Unfortunately this introduced a bunch of follow-up bugs. One of them is that the view is "forgotten" in some cases (this bug, fix linked in comment #3)

It is *not* a design complaint.
Comment 6 Thomas Lübking 2015-09-12 14:47:26 UTC 
PS: bug #352588 may better fit your efforts
Comment 7 andreas_k 2015-09-12 17:49:59 UTC 
thanks Thomas. That's the reason why I don't understand the bug. good to know. Thanks
Comment 8 Thomas Lübking 2015-09-14 20:07:24 UTC 
Git commit 584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d by Thomas Lübking.
Committed on 14/09/2015 at 19:01.
Pushed by luebking into branch 'Plasma/5.4'.

ensure to "hide" desktop buttons

before, hiding the buttons relied on the effect
seeing a paint event for the (with a low timeline
value) what's too wonky at least for instant animations
(certain failure) or when effect exits immediatey
(due to screen edge invocation issues or whatever)
FIXED-IN: 5.4.2
REVIEW: 124970

M  +10   -0    effects/desktopgrid/desktopgrid.cpp

http://commits.kde.org/kwin/584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d