Bug 351708 - Rename dialog no longer uses sane defaults.
Summary: Rename dialog no longer uses sane defaults.
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 16.12.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-24 19:12 UTC by Tonurics
Modified: 2015-09-07 21:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 15.08.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tonurics 2015-08-24 19:12:54 UTC
When using the Rename dialog [inline rename disabled] the default focus is now on the "Rename" button, it should be focused on the input box containing the file name.

Additionally, when one uses the [Enter] key while the input box is focused, the rename operation is cancelled; the [Enter] key should cause the Rename action to proceed. The [Esc] key is used for cancelling (that is working correctly).

Reproducible: Always

Steps to Reproduce:
1. Highlight a file in dolphin.
2. Press the [F2] key.

Actual Results:  
1) Rename dialog appears with the "Rename" button focused.

2) Pressing the [Enter] key while the input box is focused cancels the rename operation.

Expected Results:  
1) Rename dialog appears with the input box focused.

2) Pressing the [Enter] key while the input box is focused confirms the rename operation.

KDE Frameworks 5.13.0
Qt 5.5.0 (built against 5.5.0)
The xcb windowing system
Comment 1 Emmanuel Pescosta 2015-09-06 17:41:27 UTC
Thanks for the bug report!

> Rename dialog appears with the "Rename" button focused.

I can reproduce this ...

> Pressing the [Enter] key while the input box is focused cancels the rename operation.

... but I can't reproduce this.

Review-Request: https://git.reviewboard.kde.org/r/125078/
Comment 2 Emmanuel Pescosta 2015-09-07 21:07:28 UTC
Git commit 4143a69c05be6da8a91c8ba0db505a47b22ddc75 by Emmanuel Pescosta.
Committed on 07/09/2015 at 20:58.
Pushed by emmanuelp into branch 'Applications/15.08'.

Rename dialog: Set focus to input text box on dialog show event.
FIXED-IN: 15.08.1
REVIEW: 125078

M  +7    -1    src/views/renamedialog.cpp
M  +3    -0    src/views/renamedialog.h

http://commits.kde.org/dolphin/4143a69c05be6da8a91c8ba0db505a47b22ddc75