Bug 351550 - Default favorites mostly broken with Apps 15.08
Summary: Default favorites mostly broken with Apps 15.08
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-21 07:58 UTC by Harald Sitter
Modified: 2015-08-21 10:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2015-08-21 07:58:06 UTC
favortiesmodel.cpp has

        applications << browser << "kontact" << "systemsettings" << "dolphin" << "ktp-contactlist" << "kate";

this is referencing the desktop file names (e.g. systemsettings.desktop etc.) but due to the appstream naming transition all newly ported applications are named org.kde.foo.desktop. the default list in the cpp probably needs to be updated to fit

Reproducible: Always
Comment 1 Harald Sitter 2015-08-21 10:09:19 UTC
Git commit b2994a0f0ff3d39fecc651f9f088f5a7967e0445 by Harald Sitter.
Committed on 21/08/2015 at 08:27.
Pushed by sitter into branch 'Plasma/5.4'.

[kickoff] Fix default favorites not being initialized correctly

Desktop files changed name during KDE Frameworks 5 porting which renders
our initial favorite list defunct. By adding the new names as well as
the old ones we'll pick which ever one is actually installed on first start
such that Plasma 5.4 will also behave correctly with Applications <15.08.
REVIEW: 124863

M  +11   -1    applets/kickoff/core/favoritesmodel.cpp

http://commits.kde.org/plasma-desktop/b2994a0f0ff3d39fecc651f9f088f5a7967e0445